Revert of Remove CPDF_Object::Release() in favor of direct delete

core/fpdfapi/page/fpdf_page_parser_old.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/page/pageint.h"
 
 #include <limits.h>
 
@@ skipping 120 matching lines @@
     const uint8_t* pData,
     uint32_t dwSize,
     const CFX_WeakPtr<CFX_ByteStringPool>& pPool)
     : m_pBuf(pData),
       m_Size(dwSize),
       m_Pos(0),
       m_pLastObj(nullptr),
       m_pPool(pPool) {}
 
 CPDF_StreamParser::~CPDF_StreamParser() {
-  delete m_pLastObj;
+  if (m_pLastObj) {
+    m_pLastObj->Release();
+  }
 }
 
 CPDF_Stream* CPDF_StreamParser::ReadInlineStream(CPDF_Document* pDoc,
                                                  CPDF_Dictionary* pDict,
                                                  CPDF_Object* pCSObj) {
   if (m_Pos == m_Size)
     return nullptr;
 
   if (PDFCharIsWhitespace(m_pBuf[m_Pos]))
     m_Pos++;
@@ skipping 91 matching lines @@
     m_Pos = dwSavePos;
     pData = FX_Alloc(uint8_t, dwStreamSize);
     FXSYS_memcpy(pData, m_pBuf + m_Pos, dwStreamSize);
     m_Pos += dwStreamSize;
   }
   pDict->SetIntegerFor("Length", (int)dwStreamSize);
   return new CPDF_Stream(pData, dwStreamSize, pDict);
 }
 
 CPDF_StreamParser::SyntaxType CPDF_StreamParser::ParseNextElement() {
-  delete m_pLastObj;
-  m_pLastObj = nullptr;
+  if (m_pLastObj) {
+    m_pLastObj->Release();
+    m_pLastObj = nullptr;
+  }
 
   m_WordSize = 0;
   bool bIsNumber = true;
   if (!PositionIsInBounds())
     return EndOfData;
 
   int ch = m_pBuf[m_Pos++];
   while (1) {
     while (PDFCharIsWhitespace(ch)) {
       if (!PositionIsInBounds())
@@ skipping 98 matching lines @@
     if (m_WordSize == 1)
       return new CPDF_String(ReadHexString(), true);
 
     CPDF_Dictionary* pDict = new CPDF_Dictionary(m_pPool);
     while (1) {
       GetNextWord(bIsNumber);
       if (m_WordSize == 2 && m_WordBuffer[0] == '>')
         break;
 
       if (!m_WordSize || m_WordBuffer[0] != '/') {
-        delete pDict;
+        pDict->Release();
         return nullptr;
       }
 
       CFX_ByteString key =
           PDF_NameDecode(CFX_ByteStringC(m_WordBuffer + 1, m_WordSize - 1));
       CPDF_Object* pObj = ReadNextObject(true, 0);
       if (!pObj) {
-        delete pDict;
+        pDict->Release();
         return nullptr;
       }
 
       if (key.IsEmpty())
-        delete pObj;
+        pObj->Release();
       else
         pDict->SetFor(key, pObj);
     }
     return pDict;
   }
 
   if (first_char == '[') {
     if ((!bAllowNestedArray && dwInArrayLevel) ||
         dwInArrayLevel > kMaxNestedArrayLevel) {
       return nullptr;
@@ skipping 436 matching lines @@
       }
       m_Status = Done;
       return;
     }
     steps++;
     if (pPause && pPause->NeedToPauseNow()) {
       break;
     }
   }
 }