core/fpdfapi/parser/cfdf_document.cpp - Issue 2478253002: Revert of Remove CPDF_Object::Release() in favor of direct delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/cfdf_document.cpp

Issue 2478253002: Revert of Remove CPDF_Object::Release() in favor of direct delete (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/cfdf_document.cpp

diff --git a/core/fpdfapi/parser/cfdf_document.cpp b/core/fpdfapi/parser/cfdf_document.cpp

index dcd4b3c1094004de21170b096c4ca241262ebcf4..d39ec31d3cf55ffd3da59665cd0e3c749a47362e 100644

--- a/core/fpdfapi/parser/cfdf_document.cpp

+++ b/core/fpdfapi/parser/cfdf_document.cpp

@@ -81,7 +81,7 @@

if (CPDF_Dictionary* pMainDict =

ToDictionary(parser.GetObject(this, 0, 0, true))) {

m_pRootDict = pMainDict->GetDictFor("Root");

- delete pMainDict;

+ pMainDict->Release();

}

break;

}

« no previous file with comments | « core/fpdfapi/page/fpdf_page_parser_old.cpp ('k') | core/fpdfapi/parser/cpdf_array.h » ('j') | no next file with comments »