Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Side by Side Diff: core/fpdfapi/parser/cfdf_document.cpp

Issue 2478253002: Revert of Remove CPDF_Object::Release() in favor of direct delete (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/page/fpdf_page_parser_old.cpp ('k') | core/fpdfapi/parser/cpdf_array.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/fpdfapi/parser/cfdf_document.h" 7 #include "core/fpdfapi/parser/cfdf_document.h"
8 8
9 #include "core/fpdfapi/edit/cpdf_creator.h" 9 #include "core/fpdfapi/edit/cpdf_creator.h"
10 #include "core/fpdfapi/parser/cpdf_dictionary.h" 10 #include "core/fpdfapi/parser/cpdf_dictionary.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 word = parser.GetNextWord(nullptr); 74 word = parser.GetNextWord(nullptr);
75 if (word != "endobj") 75 if (word != "endobj")
76 break; 76 break;
77 } else { 77 } else {
78 if (word != "trailer") 78 if (word != "trailer")
79 break; 79 break;
80 80
81 if (CPDF_Dictionary* pMainDict = 81 if (CPDF_Dictionary* pMainDict =
82 ToDictionary(parser.GetObject(this, 0, 0, true))) { 82 ToDictionary(parser.GetObject(this, 0, 0, true))) {
83 m_pRootDict = pMainDict->GetDictFor("Root"); 83 m_pRootDict = pMainDict->GetDictFor("Root");
84 delete pMainDict; 84 pMainDict->Release();
85 } 85 }
86 break; 86 break;
87 } 87 }
88 } 88 }
89 } 89 }
90 90
91 bool CFDF_Document::WriteBuf(CFX_ByteTextBuf& buf) const { 91 bool CFDF_Document::WriteBuf(CFX_ByteTextBuf& buf) const {
92 if (!m_pRootDict) 92 if (!m_pRootDict)
93 return false; 93 return false;
94 94
95 buf << "%FDF-1.2\r\n"; 95 buf << "%FDF-1.2\r\n";
96 for (const auto& pair : *this) 96 for (const auto& pair : *this)
97 buf << pair.first << " 0 obj\r\n" 97 buf << pair.first << " 0 obj\r\n"
98 << pair.second.get() << "\r\nendobj\r\n\r\n"; 98 << pair.second.get() << "\r\nendobj\r\n\r\n";
99 99
100 buf << "trailer\r\n<</Root " << m_pRootDict->GetObjNum() 100 buf << "trailer\r\n<</Root " << m_pRootDict->GetObjNum()
101 << " 0 R>>\r\n%%EOF\r\n"; 101 << " 0 R>>\r\n%%EOF\r\n";
102 return true; 102 return true;
103 } 103 }
OLDNEW
« no previous file with comments | « core/fpdfapi/page/fpdf_page_parser_old.cpp ('k') | core/fpdfapi/parser/cpdf_array.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698