Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2453073002: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor (Closed)

Created:
4 years, 1 month ago by rnephew (Reviews Here)
Modified:
4 years, 1 month ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Move from telemetry WaitFor to py_utils WaitFor BUG=catapult:#2955 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/eeeba06a98740aa6e9d84cc44a1346c8c8da33bf

Patch Set 1 #

Patch Set 2 : Fix Exception Handling #

Patch Set 3 : Fix Failing Test #

Total comments: 2

Patch Set 4 : [Telemetry] Move from telemetry WaitFor to py_utils WaitFor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -204 lines) Patch
M common/py_utils/py_utils/__init__.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M telemetry/telemetry/core/android_action_runner.py View 4 chunks +4 lines, -4 lines 0 comments Download
M telemetry/telemetry/core/util.py View 1 2 3 2 chunks +7 lines, -43 lines 0 comments Download
M telemetry/telemetry/core/util_unittest.py View 1 chunk +0 lines, -37 lines 0 comments Download
M telemetry/telemetry/internal/actions/action_runner_unittest.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M telemetry/telemetry/internal/actions/load_media_unittest.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/actions/loop_unittest.py View 1 2 chunks +4 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/actions/media_action.py View 2 chunks +5 lines, -4 lines 0 comments Download
M telemetry/telemetry/internal/actions/play_unittest.py View 1 3 chunks +5 lines, -3 lines 0 comments Download
M telemetry/telemetry/internal/actions/repaint_continuously.py View 2 chunks +3 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/actions/seek_unittest.py View 1 2 chunks +4 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/backends/android_app_backend.py View 3 chunks +3 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py View 1 4 chunks +6 lines, -5 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py View 1 7 chunks +10 lines, -8 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/cros_test_case.py View 2 chunks +3 lines, -1 line 0 comments Download
M telemetry/telemetry/internal/backends/chrome/cros_unittest.py View 7 chunks +8 lines, -7 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py View 1 3 chunks +5 lines, -5 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py View 1 2 chunks +4 lines, -4 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/oobe.py View 4 chunks +7 lines, -6 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/tab_list_backend.py View 1 3 chunks +4 lines, -3 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py View 1 2 chunks +4 lines, -1 line 0 comments Download
M telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py View 2 chunks +3 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime_unittest.py View 3 chunks +4 lines, -3 lines 0 comments Download
M telemetry/telemetry/internal/backends/form_based_credentials_backend.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/browser/browser_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download
M telemetry/telemetry/internal/browser/tab_unittest.py View 1 4 chunks +6 lines, -5 lines 0 comments Download
M telemetry/telemetry/internal/browser/web_contents.py View 1 10 chunks +14 lines, -13 lines 0 comments Download
M telemetry/telemetry/internal/forwarders/cros_forwarder.py View 2 chunks +3 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/forwarders/do_nothing_forwarder.py View 1 3 chunks +4 lines, -4 lines 0 comments Download
M telemetry/telemetry/internal/forwarders/do_nothing_forwarder_unittest.py View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/platform/android_device.py View 3 chunks +2 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py View 2 chunks +3 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py View 2 chunks +3 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/platform/profiler/iprofiler_profiler.py View 2 chunks +3 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py View 2 chunks +3 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/platform/profiler/sample_profiler.py View 2 chunks +3 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/story_runner.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M telemetry/telemetry/internal/util/ts_proxy_server.py View 1 3 chunks +5 lines, -4 lines 0 comments Download
M telemetry/telemetry/internal/util/wpr_server.py View 1 3 chunks +6 lines, -5 lines 0 comments Download
M telemetry/telemetry/page/cache_temperature.py View 2 chunks +3 lines, -2 lines 0 comments Download
M telemetry/telemetry/record_wpr.py View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
rnephew (Reviews Here)
Anyone else you would like me to add as a reviewer for this?
4 years, 1 month ago (2016-10-26 22:15:21 UTC) #12
nednguyen
lgtm https://codereview.chromium.org/2453073002/diff/40001/telemetry/telemetry/core/util.py File telemetry/telemetry/core/util.py (right): https://codereview.chromium.org/2453073002/diff/40001/telemetry/telemetry/core/util.py#newcode57 telemetry/telemetry/core/util.py:57: I think you can't delete this yet because ...
4 years, 1 month ago (2016-10-26 22:18:57 UTC) #13
rnephew (Reviews Here)
https://codereview.chromium.org/2453073002/diff/40001/telemetry/telemetry/core/util.py File telemetry/telemetry/core/util.py (right): https://codereview.chromium.org/2453073002/diff/40001/telemetry/telemetry/core/util.py#newcode57 telemetry/telemetry/core/util.py:57: On 2016/10/26 22:18:57, nednguyen wrote: > I think you ...
4 years, 1 month ago (2016-10-26 22:29:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453073002/60001
4 years, 1 month ago (2016-10-26 22:30:05 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 23:15:18 UTC) #19
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698