telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py - Issue 2453073002: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py

Issue 2453073002: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor (Closed)

Patch Set: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/platform/android_device.py ('k') | telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py

diff --git a/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py b/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py

index 5795bf775b6e394907e685af1aa3b3556c2bdff5..89d141a2bd0d4786147ee6f3f2ada93a8ad2cf27 100644

--- a/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py

+++ b/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py

@@ -11,10 +11,11 @@ import tempfile

import xml.parsers.expat

from telemetry.core import os_version

-from telemetry.core import util

from telemetry import decorators

from telemetry.internal.platform import power_monitor

+import py_utils

# TODO: rename this class (seems like this is used by mac)

class PowerMetricsPowerMonitor(power_monitor.PowerMonitor):

@@ -52,7 +53,7 @@ class PowerMetricsPowerMonitor(power_monitor.PowerMonitor):

# synchronous in respect to powermetrics starting.

def _OutputFileExists():

return os.path.isfile(self._output_filename)

- util.WaitFor(_OutputFileExists, 1)

+ py_utils.WaitFor(_OutputFileExists, 1)

@decorators.Cache

def CanMonitorPower(self):