telemetry/telemetry/internal/backends/form_based_credentials_backend.py - Issue 2453073002: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/form_based_credentials_backend.py

Issue 2453073002: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor (Closed)

Patch Set: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime_unittest.py ('k') | telemetry/telemetry/internal/browser/browser_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/form_based_credentials_backend.py

diff --git a/telemetry/telemetry/internal/backends/form_based_credentials_backend.py b/telemetry/telemetry/internal/backends/form_based_credentials_backend.py

index c2c23dc69315de2e25be88dcc86fd990a8952264..1cf4c831672718c44e6764dfa6f4a0e4c6e4de1e 100644

--- a/telemetry/telemetry/internal/backends/form_based_credentials_backend.py

+++ b/telemetry/telemetry/internal/backends/form_based_credentials_backend.py

@@ -4,7 +4,8 @@

import logging

from telemetry import decorators

-from telemetry.core import exceptions

+import py_utils

class FormBasedCredentialsBackend(object):

@@ -118,7 +119,7 @@ class FormBasedCredentialsBackend(object):

self._logged_in = True

return True

- except exceptions.TimeoutException:

+ except py_utils.TimeoutException:

logging.warning('Timed out while loading: %s', url)

return False