telemetry/telemetry/internal/platform/profiler/iprofiler_profiler.py - Issue 2453073002: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/platform/profiler/iprofiler_profiler.py

Issue 2453073002: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor (Closed)

Patch Set: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py ('k') | telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/platform/profiler/iprofiler_profiler.py

diff --git a/telemetry/telemetry/internal/platform/profiler/iprofiler_profiler.py b/telemetry/telemetry/internal/platform/profiler/iprofiler_profiler.py

index e7137f807258c6ae6ea7ad45afa61f0939796b1f..bf57427a6975706a9633ff6e10320bae794a830d 100644

--- a/telemetry/telemetry/internal/platform/profiler/iprofiler_profiler.py

+++ b/telemetry/telemetry/internal/platform/profiler/iprofiler_profiler.py

@@ -7,9 +7,10 @@ import signal

import sys

from telemetry.core import exceptions

-from telemetry.core import util

from telemetry.internal.platform import profiler

+import py_utils

try:

import pexpect # pylint: disable=import-error

except ImportError:

@@ -46,7 +47,7 @@ class _SingleProcessIprofilerProfiler(object):

def Echo():

return self._proc.getecho()

- util.WaitFor(Echo, timeout=5)

+ py_utils.WaitFor(Echo, timeout=5)

def CollectProfile(self):

self._proc.kill(signal.SIGINT)