telemetry/telemetry/page/cache_temperature.py - Issue 2453073002: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/page/cache_temperature.py

Issue 2453073002: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor (Closed)

Patch Set: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/page/cache_temperature.py

diff --git a/telemetry/telemetry/page/cache_temperature.py b/telemetry/telemetry/page/cache_temperature.py

index 7d1f98194600667474a72e96043f78c3530969fb..f7d09b4f9ac52d0907ccc26845789ec31d33dc5d 100644

--- a/telemetry/telemetry/page/cache_temperature.py

+++ b/telemetry/telemetry/page/cache_temperature.py

@@ -11,7 +11,8 @@ https://docs.google.com/document/u/1/d/12D7tkhZi887g9d0U2askU9JypU_wYiEI7Lw0bfwx

"""

import logging

-from telemetry.core import util

+import py_utils

# Default Cache Temperature. The page doesn't care which browser cache state

# it is run on.

@@ -85,7 +86,7 @@ def EnsurePageCacheTemperature(page, browser, previous_page=None):

with MarkTelemetryInternal(browser, 'warmCache'):

tab = browser.tabs[0]

tab.Navigate(page.url)

- util.WaitFor(tab.HasReachedQuiescence, 60)

+ py_utils.WaitFor(tab.HasReachedQuiescence, 60)

tab.WaitForDocumentReadyStateToBeComplete()

tab.Navigate("about:blank")

tab.WaitForDocumentReadyStateToBeComplete()

« no previous file with comments | « telemetry/telemetry/internal/util/wpr_server.py ('k') | telemetry/telemetry/record_wpr.py » ('j') | no next file with comments »