telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py - Issue 2453073002: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py

Issue 2453073002: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor (Closed)

Patch Set: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py ('k') | telemetry/telemetry/internal/platform/profiler/iprofiler_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py

diff --git a/telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py b/telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py

index 137d40f91caab5de52804c8b54e94bb52ed78d5c..f58ffd05f0a2b9efde93349996b3010cddec13d5 100644

--- a/telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py

+++ b/telemetry/telemetry/internal/platform/profiler/android_traceview_profiler.py

@@ -5,10 +5,11 @@

import logging

import os

-from telemetry.core import util

from telemetry.internal.backends.chrome import android_browser_finder

from telemetry.internal.platform import profiler

+import py_utils

try:

from devil.android import device_errors # pylint: disable=import-error

except ImportError:

@@ -56,7 +57,7 @@ class AndroidTraceviewProfiler(profiler.Profiler):

for pid, trace_file in self._trace_files:

self._browser_backend.device.RunShellCommand('am profile %s stop' % pid)

# pylint: disable=cell-var-from-loop

- util.WaitFor(lambda: self._FileSize(trace_file) > 0, timeout=10)

+ py_utils.WaitFor(lambda: self._FileSize(trace_file) > 0, timeout=10)

output_files.append(trace_file)

try:

self._browser_backend.device.PullFile(