telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py - Issue 2453073002: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py

Issue 2453073002: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor (Closed)

Patch Set: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py ('k') | telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py

diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py

index c3d08b9ba5b57fea8233753bf4661b32f7703647..858568e36ac23a1422a8fb6bb3bb000baf7c8383 100644

--- a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py

+++ b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_console_unittest.py

@@ -4,9 +4,10 @@

import re

-from telemetry.core import util

from telemetry.testing import tab_test_case

+import py_utils

class TabConsoleTest(tab_test_case.TabTestCase):

def testConsoleOutputStream(self):

@@ -16,7 +17,7 @@ class TabConsoleTest(tab_test_case.TabTestCase):

def GotLog():

current = self._tab.EvaluateJavaScript('window.__logCount')

return current > initial

- util.WaitFor(GotLog, 5)

+ py_utils.WaitFor(GotLog, 5)

console_output = (

self._tab._inspector_backend.GetCurrentConsoleOutputBuffer())