telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py - Issue 2453073002: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py

Issue 2453073002: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor (Closed)

Patch Set: [Telemetry] Move from telemetry WaitFor to py_utils WaitFor Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/platform/profiler/iprofiler_profiler.py ('k') | telemetry/telemetry/internal/platform/profiler/sample_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py

diff --git a/telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py b/telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py

index e8a47bf1a699604ec9e92e331a7d08237d0a57c3..d81569353098372355c0f12aa491a7a7b02140d7 100644

--- a/telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py

+++ b/telemetry/telemetry/internal/platform/profiler/java_heap_profiler.py

@@ -8,11 +8,12 @@ import subprocess

import threading

from telemetry.core import platform

-from telemetry.core import util

from telemetry.internal.backends.chrome import android_browser_finder

from telemetry.internal.platform import profiler

from telemetry.internal.util import binary_manager

+import py_utils

try:

from devil.android import device_errors # pylint: disable=import-error

except ImportError:

@@ -87,7 +88,7 @@ class JavaHeapProfiler(profiler.Profiler):

self._browser_backend.device.RunShellCommand('am dumpheap %s %s' %

(pid, device_dump_file))

if device_dump_file and wait_for_completion:

- util.WaitFor(lambda: self._FileSize(device_dump_file) > 0, timeout=2)

+ py_utils.WaitFor(lambda: self._FileSize(device_dump_file) > 0, timeout=2)

self._run_count += 1

def _FileSize(self, file_name):