[Devtools] Cleanup DataGrid's typecast and identifier naming

[Devtools] Cleanup DataGrid's typecast and identifier naming

This patch is another part of a series to cleanup DataGrid's typeing
and ensure that we use id and removed all references to identifier.

R=dgozman,lushnikov
BUG=None

Committed: https://crrev.com/7a809ca5bb62f1d35e98070ae6bf8d03d4ce5f0e
Cr-Commit-Position: refs/heads/master@{#427464}

[allada, 2016-10-25 02:04:25]

Patchset #1 (id:1) has been deleted

[allada, 2016-10-25 02:17:17]

Patchset #1 (id:20001) has been deleted

[allada, 2016-10-25 02:17:29]

PTL

[allada, 2016-10-25 02:17:52]

Description was changed from

==========
[Devtools] Cleanup DataGrid's typecast and identifier naming

This patch is another part of a series to cleanup DataGrid's typeing
and ensure that we use id and removed all references to identifier.

R=lushnikov,dgozman
BUG=None

changes


[Devtools] Cleanup DataGrid.js

This patch simply cleansup some DataGrid a little.

R=dgozman,lushnikov
BUG=None
==========

to

==========
[Devtools] Cleanup DataGrid's typecast and identifier naming

This patch is another part of a series to cleanup DataGrid's typeing
and ensure that we use id and removed all references to identifier.

R=dgozman,lushnikov
BUG=None
==========

[allada, 2016-10-25 18:36:40]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 18:37:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 18:40:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 18:40:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dgozman, 2016-10-25 18:42:40]

lgtm

https://codereview.chromium.org/2444223002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js
(right):

https://codereview.chromium.org/2444223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js:214:
switch (parseInt(this._dataGrid.sortColumnId(), 10)) {
Compare to new ids instead.

[allada, 2016-10-25 18:56:15]

done

https://codereview.chromium.org/2444223002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js
(right):

https://codereview.chromium.org/2444223002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js:214:
switch (parseInt(this._dataGrid.sortColumnId(), 10)) {
On 2016/10/25 18:42:40, dgozman wrote:
> Compare to new ids instead.

Done.

[allada, 2016-10-25 18:57:03]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 18:57:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 20:44:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 20:44:40]

Dry run: This issue passed the CQ dry run.

[allada, 2016-10-25 20:51:38]

The CQ bit was checked by allada@chromium.org

[allada, 2016-10-25 20:51:38]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2444223002/#ps60001
(title: "changes")

[commit-bot: I haz the power, 2016-10-25 20:52:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 20:58:42]

Description was changed from

==========
[Devtools] Cleanup DataGrid's typecast and identifier naming

This patch is another part of a series to cleanup DataGrid's typeing
and ensure that we use id and removed all references to identifier.

R=dgozman,lushnikov
BUG=None
==========

to

==========
[Devtools] Cleanup DataGrid's typecast and identifier naming

This patch is another part of a series to cleanup DataGrid's typeing
and ensure that we use id and removed all references to identifier.

R=dgozman,lushnikov
BUG=None
==========

[commit-bot: I haz the power, 2016-10-25 20:58:43]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-10-25 21:00:48]

Description was changed from

==========
[Devtools] Cleanup DataGrid's typecast and identifier naming

This patch is another part of a series to cleanup DataGrid's typeing
and ensure that we use id and removed all references to identifier.

R=dgozman,lushnikov
BUG=None
==========

to

==========
[Devtools] Cleanup DataGrid's typecast and identifier naming

This patch is another part of a series to cleanup DataGrid's typeing
and ensure that we use id and removed all references to identifier.

R=dgozman,lushnikov
BUG=None

Committed: https://crrev.com/7a809ca5bb62f1d35e98070ae6bf8d03d4ce5f0e
Cr-Commit-Position: refs/heads/master@{#427464}
==========

[commit-bot: I haz the power, 2016-10-25 21:00:49]

Patchset 2 (id:??) landed as
https://crrev.com/7a809ca5bb62f1d35e98070ae6bf8d03d4ce5f0e
Cr-Commit-Position: refs/heads/master@{#427464}