Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1734)

Issue 2417723002: [Devtools] Bug fix of event dividers not showing in network panel (Closed)

Created:
4 years, 2 months ago by allada
Modified:
4 years, 2 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Bug fix of event dividers not showing in network panel Fixed bug were event dividers from film strip were not showing in network panel timeline. This was introduced when NetworkLogViewColumns was split out from NetworkLogView. Offending patch: https://codereview.chromium.org/2118663002/ R=lushnikov,dgozman BUG=655368 Committed: https://crrev.com/56149e92cd37a8b3498b87d79e0048c5ed103fc5 Cr-Commit-Position: refs/heads/master@{#424952}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 1 chunk +15 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
allada
PTL
4 years, 2 months ago (2016-10-12 23:14:25 UTC) #1
dgozman
lgtm
4 years, 2 months ago (2016-10-13 01:56:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417723002/1
4 years, 2 months ago (2016-10-13 02:37:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 04:03:48 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 04:06:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56149e92cd37a8b3498b87d79e0048c5ed103fc5
Cr-Commit-Position: refs/heads/master@{#424952}

Powered by Google App Engine
This is Rietveld 408576698