third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting.html - Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting.html

Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming (Closed)

Patch Set: changes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-containment-sorting.html ('k') | third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting.html

diff --git a/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting.html b/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting.html

index adaf26976cc8d374814af48576df1ac5a58b28f7..ae2025839ddd86cb6201a0449049bdd2aa13d9e3 100644

--- a/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting.html

+++ b/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting.html

@@ -50,8 +50,8 @@ function test()

var contents = InspectorTest.columnContents(columns[currentColumn]);

InspectorTest.assertEquals(true, !!contents.length, "column contents");

var sortTypes = { object: "text", distance: "number", count: "number", shallowSize: "size", retainedSize: "size" };

- InspectorTest.assertEquals(true, !!sortTypes[columns[currentColumn].identifier], "sort by identifier");

- InspectorTest.checkArrayIsSorted(contents, sortTypes[columns[currentColumn].identifier], columns[currentColumn].sort);

+ InspectorTest.assertEquals(true, !!sortTypes[columns[currentColumn].id], "sort by id");

+ InspectorTest.checkArrayIsSorted(contents, sortTypes[columns[currentColumn].id], columns[currentColumn].sort);

if (!currentColumnOrder)

currentColumnOrder = true;