Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html

Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming (Closed)
Patch Set: changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <html> 1 <html>
2 <head> 2 <head>
3 <script src="../../http/tests/inspector/inspector-test.js"></script> 3 <script src="../../http/tests/inspector/inspector-test.js"></script>
4 <script src="heap-snapshot-test.js"></script> 4 <script src="heap-snapshot-test.js"></script>
5 <script> 5 <script>
6 6
7 function test() 7 function test()
8 { 8 {
9 var instanceCount = 10; 9 var instanceCount = 10;
10 function createHeapSnapshot() 10 function createHeapSnapshot()
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 setTimeout(next, 0); 47 setTimeout(next, 0);
48 return; 48 return;
49 } 49 }
50 50
51 InspectorTest.clickColumn(columns[currentColumn], step4); 51 InspectorTest.clickColumn(columns[currentColumn], step4);
52 } 52 }
53 53
54 function step4(newColumnState) 54 function step4(newColumnState)
55 { 55 {
56 columns[currentColumn] = newColumnState; 56 columns[currentColumn] = newColumnState;
57 var columnName = columns[currentColumn].identifier; 57 var columnName = columns[currentColumn].id;
58 var row = InspectorTest.findRow("B"); 58 var row = InspectorTest.findRow("B");
59 InspectorTest.assertEquals(true, !!row, "\"B\" row"); 59 InspectorTest.assertEquals(true, !!row, "\"B\" row");
60 var contents = row.children.map(function(obj) { return obj.eleme nt().children[currentColumn].textContent; }); 60 var contents = row.children.map(function(obj) { return obj.eleme nt().children[currentColumn].textContent; });
61 InspectorTest.assertEquals(instanceCount, contents.length, "colu mn contents"); 61 InspectorTest.assertEquals(instanceCount, contents.length, "colu mn contents");
62 var sortTypes = { object: "text", distance: "number", count: "nu mber", shallowSize: "size", retainedSize: "size" }; 62 var sortTypes = { object: "text", distance: "number", count: "nu mber", shallowSize: "size", retainedSize: "size" };
63 InspectorTest.assertEquals(true, !!sortTypes[columns[currentColu mn].identifier], "sort by identifier"); 63 InspectorTest.assertEquals(true, !!sortTypes[columns[currentColu mn].id], "sort by id");
64 InspectorTest.checkArrayIsSorted(contents, sortTypes[columns[cur rentColumn].identifier], columns[currentColumn].sort); 64 InspectorTest.checkArrayIsSorted(contents, sortTypes[columns[cur rentColumn].id], columns[currentColumn].sort);
65 65
66 if (!currentColumnOrder) 66 if (!currentColumnOrder)
67 currentColumnOrder = true; 67 currentColumnOrder = true;
68 else { 68 else {
69 currentColumnOrder = false; 69 currentColumnOrder = false;
70 ++currentColumn; 70 ++currentColumn;
71 } 71 }
72 step3(); 72 step3();
73 } 73 }
74 } 74 }
75 ]); 75 ]);
76 } 76 }
77 77
78 </script> 78 </script>
79 </head> 79 </head>
80 <body onload="runTest()"> 80 <body onload="runTest()">
81 <p> 81 <p>
82 Tests sorting in Summary view of detailed heap snapshots. 82 Tests sorting in Summary view of detailed heap snapshots.
83 </p> 83 </p>
84 </body> 84 </body>
85 </html> 85 </html>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698