Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-comparison-sorting.html

Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming (Closed)
Patch Set: changes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-containment-sorting.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-comparison-sorting.html
diff --git a/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-comparison-sorting.html b/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-comparison-sorting.html
index b24ed26dd205fd57d6b530d717b35c7647967fc2..9187c33f63bcc4ff51418b471610cd475c463cec 100644
--- a/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-comparison-sorting.html
+++ b/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-comparison-sorting.html
@@ -59,8 +59,8 @@ function test()
var sortTypes = { object: "text",
addedCount: "number", removedCount: "number", countDelta: "number",
addedSize: "size", removedSize: "size", sizeDelta: "size" };
- InspectorTest.assertEquals(true, !!sortTypes[columns[currentColumn].identifier], "sort by identifier");
- InspectorTest.checkArrayIsSorted(contents, sortTypes[columns[currentColumn].identifier], columns[currentColumn].sort);
+ InspectorTest.assertEquals(true, !!sortTypes[columns[currentColumn].id], "sort by id");
+ InspectorTest.checkArrayIsSorted(contents, sortTypes[columns[currentColumn].id], columns[currentColumn].sort);
if (!currentColumnOrder)
currentColumnOrder = true;
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-containment-sorting.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698