[Devtools] Restructured contextMenu for DataGrid.

[Devtools] Restructured contextMenu for DataGrid.

This patch restructures the way DataGrid handles contextMenus to
be more reasonable and adds some JSDoc to DataGrid.

R=lushnikov,dgozman
BUG=None

Committed: https://crrev.com/499d8bb18168e51d21a63a3c08733eff6d57a5d1
Cr-Commit-Position: refs/heads/master@{#427832}

[allada, 2016-10-25 20:43:33]

Patchset #1 (id:1) has been deleted

[allada, 2016-10-25 20:43:40]

Patchset #1 (id:20001) has been deleted

[allada, 2016-10-25 20:44:28]

Patchset #1 (id:40001) has been deleted

[allada, 2016-10-25 20:50:41]

PTL

[allada, 2016-10-25 20:51:21]

Description was changed from

==========
[Devtools] Restructured contextMenu for DataGrid.

This patch restructures the way DataGrid handles contextMenus to
be more reasonable.

R=lushnikov,dgozman
BUG=None
==========

to

==========
[Devtools] Restructured contextMenu for DataGrid.

This patch restructures the way DataGrid handles contextMenus to
be more reasonable and adds some JSDoc to DataGrid.

R=lushnikov,dgozman
BUG=None
==========

[allada, 2016-10-25 21:10:29]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 21:10:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 00:54:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 00:54:12]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-10-26 02:36:34]

https://codereview.chromium.org/2447933002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js
(right):

https://codereview.chromium.org/2447933002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js:57:
if (readOnly)
nit: braces

https://codereview.chromium.org/2447933002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js (right):

https://codereview.chromium.org/2447933002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js:1064:
this.dispatchEventToListeners(WebInspector.DataGrid.Events.RowContextMenu, {
contextMenu: contextMenu, node: gridNode });
I feel uneasy about passing contextMenu as the argument of the event listener.

What's the point of getting rid from contextMenuCallback and switching to
events?

[allada, 2016-10-26 02:45:08]

PTL

https://codereview.chromium.org/2447933002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js
(right):

https://codereview.chromium.org/2447933002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components_lazy/CookiesTable.js:57:
if (readOnly)
On 2016/10/26 02:36:34, lushnikov wrote:
> nit: braces

Done.

https://codereview.chromium.org/2447933002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js (right):

https://codereview.chromium.org/2447933002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js:1064:
this.dispatchEventToListeners(WebInspector.DataGrid.Events.RowContextMenu, {
contextMenu: contextMenu, node: gridNode });
On 2016/10/26 02:36:34, lushnikov wrote:
> I feel uneasy about passing contextMenu as the argument of the event listener.
> 
> What's the point of getting rid from contextMenuCallback and switching to
> events?

The contextMenu was being passed to the callback before. The problem is that
datagrid always creates a contextmenu when a right click happens then sends it
down to the callback with some things that might already be attached to it.

NetworkLogView is the major user of contextMenu, but doesn't even use it's
callback. The "contextmenu" event is being consumed by datagrid which requires
NetworkLogView to attach the contextmenu event to the element of itself and
cancel the event from being propagated down to datagrid.

[allada, 2016-10-26 03:13:58]

Patchset #3 (id:100001) has been deleted

[allada, 2016-10-26 03:14:08]

Patchset #2 (id:80001) has been deleted

[allada, 2016-10-26 17:18:23]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 17:18:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 18:35:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 18:35:01]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-10-26 21:27:41]

lgtm, thanks!

Next time it would be helpful if multiple unrelated code moves happen in a
separate CL from the actual work - they make it harder to understand what's
going on

[allada, 2016-10-26 21:30:09]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2016-10-26 21:31:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 21:56:14]

Description was changed from

==========
[Devtools] Restructured contextMenu for DataGrid.

This patch restructures the way DataGrid handles contextMenus to
be more reasonable and adds some JSDoc to DataGrid.

R=lushnikov,dgozman
BUG=None
==========

to

==========
[Devtools] Restructured contextMenu for DataGrid.

This patch restructures the way DataGrid handles contextMenus to
be more reasonable and adds some JSDoc to DataGrid.

R=lushnikov,dgozman
BUG=None
==========

[commit-bot: I haz the power, 2016-10-26 21:56:18]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-10-26 22:00:07]

Description was changed from

==========
[Devtools] Restructured contextMenu for DataGrid.

This patch restructures the way DataGrid handles contextMenus to
be more reasonable and adds some JSDoc to DataGrid.

R=lushnikov,dgozman
BUG=None
==========

to

==========
[Devtools] Restructured contextMenu for DataGrid.

This patch restructures the way DataGrid handles contextMenus to
be more reasonable and adds some JSDoc to DataGrid.

R=lushnikov,dgozman
BUG=None

Committed: https://crrev.com/499d8bb18168e51d21a63a3c08733eff6d57a5d1
Cr-Commit-Position: refs/heads/master@{#427832}
==========

[commit-bot: I haz the power, 2016-10-26 22:00:08]

Patchset 2 (id:??) landed as
https://crrev.com/499d8bb18168e51d21a63a3c08733eff6d57a5d1
Cr-Commit-Position: refs/heads/master@{#427832}