third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js - Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming (Closed)

Patch Set: changes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js b/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

index 76cacc37d4c00837121499a3997425fb0ea41003..0610535e819af42c26346d6b063d4194e11911b5 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

@@ -31,11 +31,11 @@ WebInspector.ResourceWebSocketFrameView = function(request)

this._splitWidget = new WebInspector.SplitWidget(false, true, "resourceWebSocketFrameSplitViewState");

this._splitWidget.show(this.element);

- var columns = [

+ var columns = /** @type {!Array<!WebInspector.DataGrid.ColumnDescriptor>} */ ([

{id: "data", title: WebInspector.UIString("Data"), sortable: false, weight: 88},

{id: "length", title: WebInspector.UIString("Length"), sortable: false, align: WebInspector.DataGrid.Align.Right, weight: 5},

{id: "time", title: WebInspector.UIString("Time"), sortable: true, weight: 7}

- ];

+ ]);

this._dataGrid = new WebInspector.SortableDataGrid(columns, undefined, undefined, undefined, this._onContextMenu.bind(this));

this._dataGrid.setStickToBottom(true);