third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js - Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js

Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming (Closed)

Patch Set: changes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js

diff --git a/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js b/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js

index 415ffc5908206c74b1bed1ff407e2bdde49c0833..a6fd70c1e0cb3f5dd8b0cc0f3f31dfc56efac185 100644

--- a/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js

+++ b/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js

@@ -123,12 +123,12 @@ WebInspector.IDBDataView.prototype = {

{

var keyPath = this._isIndex ? this._index.keyPath : this._objectStore.keyPath;

- var columns = [];

- columns.push({id: "number", title: WebInspector.UIString("#"), width: "50px"});

- columns.push({id: "key", titleDOMFragment: this._keyColumnHeaderFragment(WebInspector.UIString("Key"), keyPath)});

+ var columns = /** @type {!Array<!WebInspector.DataGrid.ColumnDescriptor>} */ ([]);

+ columns.push({id: "number", title: WebInspector.UIString("#"), sortable: false, width: "50px"});

+ columns.push({id: "key", titleDOMFragment: this._keyColumnHeaderFragment(WebInspector.UIString("Key"), keyPath), sortable: false});

if (this._isIndex)

- columns.push({id: "primaryKey", titleDOMFragment: this._keyColumnHeaderFragment(WebInspector.UIString("Primary key"), this._objectStore.keyPath)});

- columns.push({id: "value", title: WebInspector.UIString("Value")});

+ columns.push({id: "primaryKey", titleDOMFragment: this._keyColumnHeaderFragment(WebInspector.UIString("Primary key"), this._objectStore.keyPath), sortable: false});

+ columns.push({id: "value", title: WebInspector.UIString("Value"), sortable: false});

var dataGrid = new WebInspector.DataGrid(columns);

return dataGrid;