Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2419863002: Remove uses of unittest in the HTML tests where possible. (Closed)

Created:
4 years, 2 months ago by Bob Nystrom
Modified:
4 years, 2 months ago
Reviewers:
vsm, Jacob
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove uses of unittest in the HTML tests where possible. This finishes going through the dev_compiler HTML tests and switches out unittest for minitest wherever possible. In the process, it gets another 10 tests strong mode clean, and gets several more passing, and more not skipped. With this CL, we're running another 50 more HTML tests (though some are expected to fail, mostly because of #27578). R=jacobr@google.com, vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/60a966605d310bacf76d75cbe899640d88ee9af5

Patch Set 1 #

Patch Set 2 : Remove TODO. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -476 lines) Patch
M pkg/dev_compiler/test/browser/language_tests.js View 1 5 chunks +53 lines, -90 lines 1 comment Download
M pkg/dev_compiler/test/codegen/lib/html/custom/document_register_basic_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/custom/document_register_type_extensions_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/custom/element_upgrade_test.dart View 2 chunks +3 lines, -6 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/localstorage_test.dart View 3 chunks +27 lines, -31 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/location_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/media_stream_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/mediasource_test.dart View 1 chunk +2 lines, -7 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/messageevent_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/mirrors_js_typed_interop_test.dart View 2 chunks +1 line, -4 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/mouse_event_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/navigator_test.dart View 1 chunk +3 lines, -8 lines 1 comment Download
M pkg/dev_compiler/test/codegen/lib/html/node_test.dart View 2 chunks +3 lines, -6 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart View 7 chunks +10 lines, -10 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/non_instantiated_is_test.dart View 1 chunk +3 lines, -7 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/notification_test.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/performance_api_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/private_extension_member_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/query_test.dart View 2 chunks +4 lines, -7 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/queryall_test.dart View 3 chunks +4 lines, -7 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/range_test.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/rtc_test.dart View 1 chunk +3 lines, -6 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/selectelement_test.dart View 2 chunks +4 lines, -7 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/serialized_script_value_test.dart View 1 chunk +7 lines, -8 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/shadow_dom_test.dart View 2 chunks +2 lines, -6 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/shadowroot_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/speechrecognition_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/storage_test.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/streams_test.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/svg_test.dart View 4 chunks +10 lines, -10 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/svgelement_test.dart View 2 chunks +6 lines, -10 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/table_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/touchevent_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/track_element_constructor_test.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/trusted_html_tree_sanitizer_test.dart View 2 chunks +4 lines, -7 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/typed_arrays_1_test.dart View 2 chunks +8 lines, -9 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/typed_arrays_2_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/typed_arrays_3_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/typed_arrays_4_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/typed_arrays_5_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/typed_arrays_arraybuffer_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/typed_arrays_dataview_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/typed_arrays_range_checks_test.dart View 3 chunks +3 lines, -26 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/typed_arrays_simd_test.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/typing_test.dart View 2 chunks +7 lines, -9 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/unknownelement_test.dart View 1 chunk +4 lines, -7 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/uri_test.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/webgl_1_test.dart View 5 chunks +11 lines, -10 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/window_eq_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/window_mangling_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/window_nosuchmethod_test.dart View 3 chunks +7 lines, -23 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/window_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/wrapping_collections_test.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/dev_compiler/test/codegen/lib/html/xsltprocessor_test.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/dev_compiler/test/not_yet_strong_tests.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M pkg/expect/lib/minitest.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Bob Nystrom
4 years, 2 months ago (2016-10-13 21:20:30 UTC) #2
vsm
lgtm!
4 years, 2 months ago (2016-10-14 16:04:15 UTC) #3
Jacob
lgtm https://codereview.chromium.org/2419863002/diff/20001/pkg/dev_compiler/test/browser/language_tests.js File pkg/dev_compiler/test/browser/language_tests.js (right): https://codereview.chromium.org/2419863002/diff/20001/pkg/dev_compiler/test/browser/language_tests.js#newcode784 pkg/dev_compiler/test/browser/language_tests.js:784: console.log("cleared"); remove console.log message https://codereview.chromium.org/2419863002/diff/20001/pkg/dev_compiler/test/codegen/lib/html/navigator_test.dart File pkg/dev_compiler/test/codegen/lib/html/navigator_test.dart (right): ...
4 years, 2 months ago (2016-10-14 16:44:38 UTC) #4
Bob Nystrom
4 years, 2 months ago (2016-10-14 20:44:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
60a966605d310bacf76d75cbe899640d88ee9af5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698