pkg/dev_compiler/test/codegen/lib/html/custom/element_upgrade_test.dart - Issue 2419863002: Remove uses of unittest in the HTML tests where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/test/codegen/lib/html/custom/element_upgrade_test.dart

Issue 2419863002: Remove uses of unittest in the HTML tests where possible. (Closed)

Patch Set: Remove TODO. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/dev_compiler/test/browser/language_tests.js ('K') | « pkg/dev_compiler/test/codegen/lib/html/custom/document_register_type_extensions_test.dart ('k') | pkg/dev_compiler/test/codegen/lib/html/localstorage_test.dart » ('j') | pkg/dev_compiler/test/codegen/lib/html/navigator_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/dev_compiler/test/codegen/lib/html/custom/element_upgrade_test.dart

diff --git a/pkg/dev_compiler/test/codegen/lib/html/custom/element_upgrade_test.dart b/pkg/dev_compiler/test/codegen/lib/html/custom/element_upgrade_test.dart

index c8e7376ea4516a109427c02b646694f50427ce21..a1f071b5c54e34c15e17ddfef5259c1c05413e92 100644

--- a/pkg/dev_compiler/test/codegen/lib/html/custom/element_upgrade_test.dart

+++ b/pkg/dev_compiler/test/codegen/lib/html/custom/element_upgrade_test.dart

@@ -2,13 +2,12 @@

// BSD-style license that can be found in the LICENSE file.

-library register_element_proxy_test;

import 'dart:async';

import 'dart:html';

import 'dart:js' as js;

-import 'package:unittest/html_config.dart';

-import 'package:unittest/unittest.dart';

+import 'package:expect/minitest.dart';

import '../utils.dart';

class FooElement extends HtmlElement {

@@ -28,8 +27,6 @@ class FooElement extends HtmlElement {

}

main() {

- useHtmlConfiguration();

var registered = false;

var upgrader;

setUp(() => customElementsReady.then((_) {