pkg/dev_compiler/test/codegen/lib/html/navigator_test.dart - Issue 2419863002: Remove uses of unittest in the HTML tests where possible.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pkg/dev_compiler/test/codegen/lib/html/navigator_test.dart

Issue 2419863002: Remove uses of unittest in the HTML tests where possible. (Closed)

Patch Set: Remove TODO. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 library NavigatorTest;

2 import 'package:unittest/unittest.dart';

3 import 'package:unittest/html_config.dart';

4 import 'dart:html';	1 import 'dart:html';

5	2

	3 import 'package:expect/expect.dart';

	4

6 main() {	5 main() {

7 useHtmlConfiguration();	6 Expect.isNotNull(window.navigator.language);
	Jacob 2016/10/14 16:44:38 nit: why delete the test block here? I know the te nit: why delete the test block here? I know the test name is somewhat obvious from the expect but still deems reasonable to make summaries of errors look nice.
8

9 test('language never returns null', () {

10 expect(window.navigator.language, isNotNull);

11 });

12 }	7 }

OLD	NEW