Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: pkg/dev_compiler/test/codegen/lib/html/window_nosuchmethod_test.dart

Issue 2419863002: Remove uses of unittest in the HTML tests where possible. (Closed)
Patch Set: Remove TODO. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/test/codegen/lib/html/window_nosuchmethod_test.dart
diff --git a/pkg/dev_compiler/test/codegen/lib/html/window_nosuchmethod_test.dart b/pkg/dev_compiler/test/codegen/lib/html/window_nosuchmethod_test.dart
index 93cb592e0746d0523b467521d48fee0a2d26a654..4cc84b4f49f8ca2c4bb9e0df21307ddef166c6f8 100644
--- a/pkg/dev_compiler/test/codegen/lib/html/window_nosuchmethod_test.dart
+++ b/pkg/dev_compiler/test/codegen/lib/html/window_nosuchmethod_test.dart
@@ -2,12 +2,10 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library WindowNSMETest;
-import "package:expect/expect.dart";
-import 'package:unittest/unittest.dart';
-import 'package:unittest/html_config.dart';
import 'dart:html' as dom;
+import 'package:expect/minitest.dart';
+
// Not defined in dom.Window.
foo(x) => x;
@@ -18,20 +16,12 @@ class Unused {
int inscrutable(int x) => x == 0 ? 0 : x | inscrutable(x & (x - 1));
main() {
- useHtmlConfiguration();
- var things = [new Unused(), dom.window];
+ var things = <dynamic>[new Unused(), dom.window];
test('windowNonMethod', () {
var win = things[inscrutable(1)];
final message = foo("Hello World");
- try {
- String x = win.foo(message);
- expect(false, isTrue, reason: 'Should not reach here: $x');
- } on NoSuchMethodError catch (e) {
- // Expected exception.
- } on Exception catch (e) {
- expect(false, isTrue, reason: 'Wrong exception: $e');
- }
+ expect(() => win.foo(message), throwsNoSuchMethodError);
});
test('foo', () {
@@ -40,16 +30,10 @@ main() {
expect(x, 'not bar');
});
- // Use dom.window direclty in case the compiler does type inference.
+ // Use dom.window directly in case the compiler does type inference.
test('windowNonMethod2', () {
final message = foo("Hello World");
- try {
- String x = dom.window.foo(message);
- expect(false, isTrue, reason: 'Should not reach here: $x');
- } on NoSuchMethodError catch (e) {
- // Expected exception.
- } on Exception catch (e) {
- expect(false, isTrue, reason: 'Wrong exception: $e');
- }
+ expect(() => (dom.window as dynamic).foo(message),
+ throwsNoSuchMethodError);
});
}

Powered by Google App Engine
This is Rietveld 408576698