Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: pkg/dev_compiler/test/codegen/lib/html/queryall_test.dart

Issue 2419863002: Remove uses of unittest in the HTML tests where possible. (Closed)
Patch Set: Remove TODO. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/test/codegen/lib/html/queryall_test.dart
diff --git a/pkg/dev_compiler/test/codegen/lib/html/queryall_test.dart b/pkg/dev_compiler/test/codegen/lib/html/queryall_test.dart
index be4e67b5eaed2368fb3f56b9197f768f500e9a0a..c8c00f98022a378d0c6294a1feb61b878596c46b 100644
--- a/pkg/dev_compiler/test/codegen/lib/html/queryall_test.dart
+++ b/pkg/dev_compiler/test/codegen/lib/html/queryall_test.dart
@@ -2,14 +2,11 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file
-library NodeListTest;
-import 'package:unittest/unittest.dart';
-import 'package:unittest/html_config.dart';
import 'dart:html';
-main() {
- useHtmlConfiguration();
+import 'package:expect/minitest.dart';
+main() {
var isElement = predicate((x) => x is Element, 'is an Element');
var isCanvasElement =
predicate((x) => x is CanvasElement, 'is a CanvasElement');
@@ -45,7 +42,7 @@ main() {
});
test('queryAll-canvas', () {
- List<CanvasElement> all = queryAll('canvas');
+ var all = queryAll('canvas');
for (var e in all) {
expect(e, isCanvasElement);
}
@@ -61,7 +58,7 @@ main() {
test('queryAll-where', () {
List<Element> all = queryAll('*');
- Iterable<CanvasElement> canvases = all.where((e) => e is CanvasElement);
+ var canvases = all.where((e) => e is CanvasElement);
for (var e in canvases) {
expect(e is CanvasElement, isTrue);
}

Powered by Google App Engine
This is Rietveld 408576698