Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: pkg/dev_compiler/test/codegen/lib/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart

Issue 2419863002: Remove uses of unittest in the HTML tests where possible. (Closed)
Patch Set: Remove TODO. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/test/codegen/lib/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart
diff --git a/pkg/dev_compiler/test/codegen/lib/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart b/pkg/dev_compiler/test/codegen/lib/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart
index 4d7d338393c0cd11ac0cd3648f5dc545e8f76381..84821ffb9c24cd33f43e16e7a920d46b59e52035 100644
--- a/pkg/dev_compiler/test/codegen/lib/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart
+++ b/pkg/dev_compiler/test/codegen/lib/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart
@@ -10,8 +10,9 @@ library node_validator_test;
import 'dart:html';
import 'dart:svg' as svg;
-import 'package:unittest/unittest.dart';
-import 'package:unittest/html_individual_config.dart';
+
+import 'package:expect/minitest.dart';
+
import 'utils.dart';
void validateHtml(String html, String reference, NodeValidator validator) {
@@ -52,8 +53,6 @@ void testHtml(String name, NodeValidator validator, String html,
}
main() {
- useHtmlIndividualConfiguration();
-
group('DOM_sanitization', () {
var validator = new NodeValidatorBuilder.common();
@@ -126,7 +125,7 @@ main() {
'</template>';
var fragment = document.body.createFragment(html, validator: validator);
- var template = fragment.nodes.single;
+ var template = fragment.nodes.single as TemplateElement;
var expectedContent = document.body.createFragment(
'<div></div>'
@@ -149,8 +148,9 @@ main() {
var fragment = new DocumentFragment.html(html);
fragment.appendHtml('<div id="bad"><script></script></div>');
expect(fragment.childNodes.length, 1);
- expect(fragment.childNodes[0].id, "bad");
- expect(fragment.childNodes[0].childNodes.length, 0);
+ var child = fragment.childNodes[0] as Element;
+ expect(child.id, "bad");
+ expect(child.childNodes.length, 0);
});
testHtml("sanitizes embed",
@@ -500,7 +500,7 @@ main() {
'</svg>';
var fragment = new DocumentFragment.svg(svgText);
- var element = fragment.nodes.first;
+ var element = fragment.nodes.first as Element;
expect(element is svg.SvgSvgElement, isTrue);
expect(element.children[0] is svg.ImageElement, isTrue);
});
@@ -542,7 +542,7 @@ main() {
var fragment = document.body.createFragment(
"<form onmouseover='alert(2)'><input name='tagName'>",
validator: validator);
- var form = fragment.lastChild;
+ var form = fragment.lastChild as FormElement;
// If the tagName was clobbered, the sanitizer should have removed
// the whole thing and form is null.
// If the tagName was not clobbered, then there will be content,
@@ -557,7 +557,7 @@ main() {
var fragment = document.body.createFragment(
"<form><input name='tagName'>",
validator: validator);
- var form = fragment.lastChild;
+ var form = fragment.lastChild as FormElement;
// If the tagName was clobbered, the sanitizer should have removed
// the whole thing and form is null.
// If the tagName was not clobbered, then there will be content,

Powered by Google App Engine
This is Rietveld 408576698