Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: pkg/dev_compiler/test/codegen/lib/html/webgl_1_test.dart

Issue 2419863002: Remove uses of unittest in the HTML tests where possible. (Closed)
Patch Set: Remove TODO. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/test/codegen/lib/html/webgl_1_test.dart
diff --git a/pkg/dev_compiler/test/codegen/lib/html/webgl_1_test.dart b/pkg/dev_compiler/test/codegen/lib/html/webgl_1_test.dart
index d6e6f1f4cadd2cbd04ed87ec21ac3b923609cd3e..ce296ee82f21e2eea29628b2b9c626b0c4a7c8c5 100644
--- a/pkg/dev_compiler/test/codegen/lib/html/webgl_1_test.dart
+++ b/pkg/dev_compiler/test/codegen/lib/html/webgl_1_test.dart
@@ -2,19 +2,19 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library web_gl_test;
-import 'package:unittest/unittest.dart';
-import 'package:unittest/html_individual_config.dart';
import 'dart:html';
import 'dart:typed_data';
import 'dart:web_gl';
import 'dart:web_gl' as gl;
+import 'package:expect/minitest.dart';
+
// Test that WebGL is present in dart:web_gl API
-main() {
- useHtmlIndividualConfiguration();
+final isRenderingContext = predicate((x) => x is RenderingContext);
+final isContextAttributes = predicate((x) => x is gl.ContextAttributes);
+main() {
group('supported', () {
test('supported', () {
expect(RenderingContext.supported, isTrue);
@@ -27,7 +27,7 @@ main() {
var context = canvas.getContext3d();
if (RenderingContext.supported) {
expect(context, isNotNull);
- expect(context, new isInstanceOf<RenderingContext>());
+ expect(context, isRenderingContext);
} else {
expect(context, isNull);
}
@@ -36,7 +36,8 @@ main() {
if (RenderingContext.supported) {
test('simple', () {
var canvas = new CanvasElement();
- var context = canvas.getContext('experimental-webgl');
+ var context =
+ canvas.getContext('experimental-webgl') as gl.RenderingContext;
var shader = context.createShader(gl.VERTEX_SHADER);
context.shaderSource(shader, 'void main() { }');
context.compileShader(shader);
@@ -48,11 +49,11 @@ main() {
var canvas = new CanvasElement();
var context = canvas.getContext3d();
expect(context, isNotNull);
- expect(context, new isInstanceOf<RenderingContext>());
+ expect(context, isRenderingContext);
context = canvas.getContext3d(depth: false);
expect(context, isNotNull);
- expect(context, new isInstanceOf<RenderingContext>());
+ expect(context, isRenderingContext);
});
test('texImage2D', () {
@@ -95,7 +96,7 @@ main() {
var attributes = context.getContextAttributes();
expect(attributes, isNotNull);
- expect(attributes, new isInstanceOf<gl.ContextAttributes>());
+ expect(attributes, isContextAttributes);
expect(attributes.alpha, isBoolean);
expect(attributes.antialias, isBoolean);

Powered by Google App Engine
This is Rietveld 408576698