Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: pkg/dev_compiler/test/codegen/lib/html/typing_test.dart

Issue 2419863002: Remove uses of unittest in the HTML tests where possible. (Closed)
Patch Set: Remove TODO. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 library TypingTest;
2 import 'package:unittest/unittest.dart';
3 import 'package:unittest/html_config.dart';
4 import 'dart:html'; 1 import 'dart:html';
5 2
3 import 'package:expect/minitest.dart';
4
6 main() { 5 main() {
7 useHtmlConfiguration();
8
9 var isStyleSheetList = 6 var isStyleSheetList =
10 predicate((x) => x is List<StyleSheet>, 'is a List<StyleSheet>'); 7 predicate((x) => x is List<StyleSheet>, 'is a List<StyleSheet>');
11 8
12 test('NodeList', () { 9 test('NodeList', () {
13 List<Node> asList = window.document.queryAll('body'); 10 List<Node> asList = window.document.queryAll('body');
14 // Check it's Iterable 11 // Check it's Iterable
15 int counter = 0; 12 int counter = 0;
16 for (Node node in window.document.queryAll('body')) { 13 for (Node node in window.document.queryAll('body')) {
17 counter++; 14 counter++;
18 } 15 }
19 expect(counter, 1); 16 expect(counter, 1);
20 counter = 0; 17 counter = 0;
21 window.document.queryAll('body').forEach((e) { counter++; }); 18 window.document.queryAll('body').forEach((e) { counter++; });
22 expect(counter, 1); 19 expect(counter, 1);
23 }); 20 });
24 21
25 test('StyleSheetList', () { 22 test('StyleSheetList', () {
26 List<StyleSheet> asList = window.document.styleSheets; 23 var document = window.document as HtmlDocument;
24 List<StyleSheet> asList = document.styleSheets;
27 expect(asList, isStyleSheetList); 25 expect(asList, isStyleSheetList);
28 // Check it's Iterable. 26 // Check it's Iterable.
29 int counter = 0; 27 int counter = 0;
30 for (StyleSheet styleSheet in window.document.styleSheets) { 28 for (StyleSheet styleSheet in document.styleSheets) {
31 counter++; 29 counter++;
32 } 30 }
33 31
34 // There is one style sheet from the unittest framework. 32 // There are no style sheets.
35 expect(counter, 1); 33 expect(counter, 0);
36 }); 34 });
37 } 35 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698