Pass isolate to v8::Undefined() function

Pass isolate to v8::Undefined() function

Pass isolate to v8::Undefined() function to avoid implicit call to
v8::Isolate::GetCurrent().

R=haraken
BUG=263412
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157782

[do-not-use, 2013-09-12 07:54:09]

Adding abarth for Source/web

[haraken, 2013-09-12 09:31:20]

LGTM. v8::Undefined(isolate) always performs better than v8::Undefined(), so
this change makes sense.

One thing we might want to consider is whether we should use Undefined(isolate)
or Handle<Value>(). Because previously Handle<Value>() was faster than
Undefined(isolate), we're currently using Handle<Value>() instead of
Undefined(isolate) in a lot of places as a performance hack. I think Michael has
already solved the performance problem, so we can replace all Handle<Value>()
with Undefined(isolate). We need to double-check the performance using some
micro benchmark.

[do-not-use, 2013-09-13 16:02:13]

abarth@, could you please take a look for Source/web ?

[abarth-chromium, 2013-09-13 17:48:02]

LGTM

Can we add per-file OWNERS for WebBindings to let the Source/bindings OWNERS
review changes to that file?

[commit-bot: I haz the power, 2013-09-13 17:48:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/24118003/1

[commit-bot: I haz the power, 2013-09-13 17:48:35]

Failed to apply patch for Source/bindings/v8/custom/V8PromiseResolverCustom.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/v8/custom/V8PromiseResolverCustom.cpp
  Hunk #1 FAILED at 48.
  Hunk #2 FAILED at 65.
  Hunk #3 FAILED at 82.
  3 out of 3 hunks FAILED -- saving rejects to file
Source/bindings/v8/custom/V8PromiseResolverCustom.cpp.rej

Patch:       Source/bindings/v8/custom/V8PromiseResolverCustom.cpp
Index: Source/bindings/v8/custom/V8PromiseResolverCustom.cpp
diff --git a/Source/bindings/v8/custom/V8PromiseResolverCustom.cpp
b/Source/bindings/v8/custom/V8PromiseResolverCustom.cpp
index
19c8da7ee8fa5048bcb9f03cd075d47b1087aac7..fdf103be672b45af77cbbfd4b5cdac8bf2ad95fa
100644
--- a/Source/bindings/v8/custom/V8PromiseResolverCustom.cpp
+++ b/Source/bindings/v8/custom/V8PromiseResolverCustom.cpp
@@ -48,7 +48,7 @@ void V8PromiseResolver::fulfillMethodCustom(const
v8::FunctionCallbackInfo<v8::V
     V8PromiseCustom::setState(internal,
V8PromiseCustom::PendingWithResolvedFlagSet);
 
     v8::Isolate* isolate = args.GetIsolate();
-    v8::Local<v8::Value> result = v8::Undefined();
+    v8::Local<v8::Value> result = v8::Undefined(isolate);
     if (args.Length() > 0)
         result = args[0];
     V8PromiseCustom::fulfillResolver(resolver, result,
V8PromiseCustom::Asynchronous, isolate);
@@ -65,7 +65,7 @@ void V8PromiseResolver::resolveMethodCustom(const
v8::FunctionCallbackInfo<v8::V
     V8PromiseCustom::setState(internal,
V8PromiseCustom::PendingWithResolvedFlagSet);
 
     v8::Isolate* isolate = args.GetIsolate();
-    v8::Local<v8::Value> result = v8::Undefined();
+    v8::Local<v8::Value> result = v8::Undefined(isolate);
     if (args.Length() > 0)
         result = args[0];
     V8PromiseCustom::resolveResolver(resolver, result,
V8PromiseCustom::Asynchronous, isolate);
@@ -82,7 +82,7 @@ void V8PromiseResolver::rejectMethodCustom(const
v8::FunctionCallbackInfo<v8::Va
     V8PromiseCustom::setState(internal,
V8PromiseCustom::PendingWithResolvedFlagSet);
 
     v8::Isolate* isolate = args.GetIsolate();
-    v8::Local<v8::Value> result = v8::Undefined();
+    v8::Local<v8::Value> result = v8::Undefined(isolate);
     if (args.Length() > 0)
         result = args[0];
     V8PromiseCustom::rejectResolver(resolver, result,
V8PromiseCustom::Asynchronous, isolate);

[commit-bot: I haz the power, 2013-09-13 18:28:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/24118003/13001

[commit-bot: I haz the power, 2013-09-13 20:42:36]

Change committed as 157782