Source/bindings/v8/V8AbstractEventListener.cpp - Issue 24118003: Pass isolate to v8::Undefined() function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8AbstractEventListener.cpp

Issue 24118003: Pass isolate to v8::Undefined() function (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8AbstractEventListener.cpp

diff --git a/Source/bindings/v8/V8AbstractEventListener.cpp b/Source/bindings/v8/V8AbstractEventListener.cpp

index e6b3de91b411885d3368a198eb5479c802da8b5e..0f3469c472aa35de9926be54d89d3752052a6f20 100644

--- a/Source/bindings/v8/V8AbstractEventListener.cpp

+++ b/Source/bindings/v8/V8AbstractEventListener.cpp

@@ -142,7 +142,7 @@ void V8AbstractEventListener::invokeEventHandler(ScriptExecutionContext* context

// Restore the old event. This must be done for all exit paths through this method.

if (savedEvent.IsEmpty())

- v8Context->Global()->SetHiddenValue(eventSymbol, v8::Undefined());

+ v8Context->Global()->SetHiddenValue(eventSymbol, v8::Undefined(v8Context->GetIsolate()));

else

v8Context->Global()->SetHiddenValue(eventSymbol, savedEvent);

tryCatch.Reset();

« no previous file with comments | « Source/bindings/v8/SerializedScriptValue.cpp ('k') | Source/bindings/v8/V8Binding.h » ('j') | no next file with comments »