Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp - Issue 24118003: Pass isolate to v8::Undefined() function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 24118003: Pass isolate to v8::Undefined() function (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp b/Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

index dbbd02c82fcebd06a7926f6b44aadc34eb8266c0..e0d69f27a4448c1236202193b9928a2ba60ee877 100644

--- a/Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

@@ -64,7 +64,7 @@ static v8::Handle<v8::Value> getItem(HTMLAllCollection* collection, v8::Handle<v

v8::Handle<v8::Value> result = getNamedItems(collection, toWebCoreString(argument->ToString()), callbackInfo);

if (result.IsEmpty())

- return v8::Undefined();

+ return v8::Undefined(callbackInfo.GetIsolate());

return result;

}