Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: Source/bindings/v8/custom/V8PromiseResolverCustom.cpp

Issue 24118003: Pass isolate to v8::Undefined() function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 30 matching lines...) Expand all
41 { 41 {
42 v8::Local<v8::Object> resolver = args.This(); 42 v8::Local<v8::Object> resolver = args.This();
43 if (V8PromiseCustom::isInternalDetached(resolver)) 43 if (V8PromiseCustom::isInternalDetached(resolver))
44 return; 44 return;
45 v8::Local<v8::Object> internal = V8PromiseCustom::getInternal(resolver); 45 v8::Local<v8::Object> internal = V8PromiseCustom::getInternal(resolver);
46 if (V8PromiseCustom::getState(internal) != V8PromiseCustom::Pending) 46 if (V8PromiseCustom::getState(internal) != V8PromiseCustom::Pending)
47 return; 47 return;
48 v8::Isolate* isolate = args.GetIsolate(); 48 v8::Isolate* isolate = args.GetIsolate();
49 V8PromiseCustom::setState(internal, V8PromiseCustom::PendingWithResolvedFlag Set, isolate); 49 V8PromiseCustom::setState(internal, V8PromiseCustom::PendingWithResolvedFlag Set, isolate);
50 50
51 v8::Local<v8::Value> result = v8::Undefined(); 51 v8::Local<v8::Value> result = v8::Undefined(isolate);
52 if (args.Length() > 0) 52 if (args.Length() > 0)
53 result = args[0]; 53 result = args[0];
54 V8PromiseCustom::fulfillResolver(resolver, result, V8PromiseCustom::Asynchro nous, isolate); 54 V8PromiseCustom::fulfillResolver(resolver, result, V8PromiseCustom::Asynchro nous, isolate);
55 } 55 }
56 56
57 void V8PromiseResolver::resolveMethodCustom(const v8::FunctionCallbackInfo<v8::V alue>& args) 57 void V8PromiseResolver::resolveMethodCustom(const v8::FunctionCallbackInfo<v8::V alue>& args)
58 { 58 {
59 v8::Local<v8::Object> resolver = args.This(); 59 v8::Local<v8::Object> resolver = args.This();
60 if (V8PromiseCustom::isInternalDetached(resolver)) 60 if (V8PromiseCustom::isInternalDetached(resolver))
61 return; 61 return;
62 v8::Local<v8::Object> internal = V8PromiseCustom::getInternal(resolver); 62 v8::Local<v8::Object> internal = V8PromiseCustom::getInternal(resolver);
63 if (V8PromiseCustom::getState(internal) != V8PromiseCustom::Pending) 63 if (V8PromiseCustom::getState(internal) != V8PromiseCustom::Pending)
64 return; 64 return;
65 v8::Isolate* isolate = args.GetIsolate(); 65 v8::Isolate* isolate = args.GetIsolate();
66 V8PromiseCustom::setState(internal, V8PromiseCustom::PendingWithResolvedFlag Set, isolate); 66 V8PromiseCustom::setState(internal, V8PromiseCustom::PendingWithResolvedFlag Set, isolate);
67 67
68 v8::Local<v8::Value> result = v8::Undefined(); 68 v8::Local<v8::Value> result = v8::Undefined(isolate);
69 if (args.Length() > 0) 69 if (args.Length() > 0)
70 result = args[0]; 70 result = args[0];
71 V8PromiseCustom::resolveResolver(resolver, result, V8PromiseCustom::Asynchro nous, isolate); 71 V8PromiseCustom::resolveResolver(resolver, result, V8PromiseCustom::Asynchro nous, isolate);
72 } 72 }
73 73
74 void V8PromiseResolver::rejectMethodCustom(const v8::FunctionCallbackInfo<v8::Va lue>& args) 74 void V8PromiseResolver::rejectMethodCustom(const v8::FunctionCallbackInfo<v8::Va lue>& args)
75 { 75 {
76 v8::Local<v8::Object> resolver = args.This(); 76 v8::Local<v8::Object> resolver = args.This();
77 if (V8PromiseCustom::isInternalDetached(resolver)) 77 if (V8PromiseCustom::isInternalDetached(resolver))
78 return; 78 return;
79 v8::Local<v8::Object> internal = V8PromiseCustom::getInternal(resolver); 79 v8::Local<v8::Object> internal = V8PromiseCustom::getInternal(resolver);
80 if (V8PromiseCustom::getState(internal) != V8PromiseCustom::Pending) 80 if (V8PromiseCustom::getState(internal) != V8PromiseCustom::Pending)
81 return; 81 return;
82 v8::Isolate* isolate = args.GetIsolate(); 82 v8::Isolate* isolate = args.GetIsolate();
83 V8PromiseCustom::setState(internal, V8PromiseCustom::PendingWithResolvedFlag Set, isolate); 83 V8PromiseCustom::setState(internal, V8PromiseCustom::PendingWithResolvedFlag Set, isolate);
84 84
85 v8::Local<v8::Value> result = v8::Undefined(); 85 v8::Local<v8::Value> result = v8::Undefined(isolate);
86 if (args.Length() > 0) 86 if (args.Length() > 0)
87 result = args[0]; 87 result = args[0];
88 V8PromiseCustom::rejectResolver(resolver, result, V8PromiseCustom::Asynchron ous, isolate); 88 V8PromiseCustom::rejectResolver(resolver, result, V8PromiseCustom::Asynchron ous, isolate);
89 } 89 }
90 90
91 } // namespace WebCore 91 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8IDBAnyCustom.cpp ('k') | Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698