Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 24118003: Pass isolate to v8::Undefined() function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/V8TestObject.cpp b/Source/bindings/tests/results/V8TestObject.cpp
index 19bfdb563b94aea9d4641f03851de15ecf1c868d..2a9a0915ed429a19b21e120469c05014a4e45a35 100644
--- a/Source/bindings/tests/results/V8TestObject.cpp
+++ b/Source/bindings/tests/results/V8TestObject.cpp
@@ -1060,7 +1060,7 @@ static void withScriptStateAttributeAttributeSetter(v8::Local<v8::String> name,
ScriptState& state = *currentState;
imp->setWithScriptStateAttribute(&state, v);
if (state.hadException())
- throwError(state.exception());
+ throwError(state.exception(), info.GetIsolate());
return;
}
@@ -1143,7 +1143,7 @@ static void withScriptStateAttributeRaisesAttributeGetter(v8::Local<v8::String>
if (UNLIKELY(es.throwIfNeeded()))
return;
if (state.hadException()) {
- throwError(state.exception());
+ throwError(state.exception(), info.GetIsolate());
return;
}
v8SetReturnValueFast(info, v.release(), imp);
@@ -1167,7 +1167,7 @@ static void withScriptStateAttributeRaisesAttributeSetter(v8::Local<v8::String>
ScriptState& state = *currentState;
imp->setWithScriptStateAttributeRaises(&state, WTF::getPtr(v));
if (state.hadException())
- throwError(state.exception());
+ throwError(state.exception(), info.GetIsolate());
return;
}
@@ -1243,7 +1243,7 @@ static void withScriptExecutionContextAndScriptStateAttributeAttributeSetter(v8:
ScriptExecutionContext* scriptContext = getScriptExecutionContext();
imp->setWithScriptExecutionContextAndScriptStateAttribute(&state, scriptContext, WTF::getPtr(v));
if (state.hadException())
- throwError(state.exception());
+ throwError(state.exception(), info.GetIsolate());
return;
}
@@ -1267,7 +1267,7 @@ static void withScriptExecutionContextAndScriptStateAttributeRaisesAttributeGett
if (UNLIKELY(es.throwIfNeeded()))
return;
if (state.hadException()) {
- throwError(state.exception());
+ throwError(state.exception(), info.GetIsolate());
return;
}
v8SetReturnValueFast(info, v.release(), imp);
@@ -1292,7 +1292,7 @@ static void withScriptExecutionContextAndScriptStateAttributeRaisesAttributeSett
ScriptExecutionContext* scriptContext = getScriptExecutionContext();
imp->setWithScriptExecutionContextAndScriptStateAttributeRaises(&state, scriptContext, WTF::getPtr(v));
if (state.hadException())
- throwError(state.exception());
+ throwError(state.exception(), info.GetIsolate());
return;
}
@@ -1333,7 +1333,7 @@ static void withScriptExecutionContextAndScriptStateWithSpacesAttributeAttribute
ScriptExecutionContext* scriptContext = getScriptExecutionContext();
imp->setWithScriptExecutionContextAndScriptStateWithSpacesAttribute(&state, scriptContext, WTF::getPtr(v));
if (state.hadException())
- throwError(state.exception());
+ throwError(state.exception(), info.GetIsolate());
return;
}
@@ -3295,7 +3295,7 @@ static void withScriptStateVoidMethod(const v8::FunctionCallbackInfo<v8::Value>&
if (state.hadException()) {
v8::Local<v8::Value> exception = state.exception();
state.clearException();
- throwError(exception);
+ throwError(exception, args.GetIsolate());
return;
}
@@ -3320,7 +3320,7 @@ static void withScriptStateObjMethod(const v8::FunctionCallbackInfo<v8::Value>&
if (state.hadException()) {
v8::Local<v8::Value> exception = state.exception();
state.clearException();
- throwError(exception);
+ throwError(exception, args.GetIsolate());
return;
}
v8SetReturnValue(args, result.release(), args.Holder());
@@ -3348,7 +3348,7 @@ static void withScriptStateVoidExceptionMethod(const v8::FunctionCallbackInfo<v8
if (state.hadException()) {
v8::Local<v8::Value> exception = state.exception();
state.clearException();
- throwError(exception);
+ throwError(exception, args.GetIsolate());
return;
}
@@ -3376,7 +3376,7 @@ static void withScriptStateObjExceptionMethod(const v8::FunctionCallbackInfo<v8:
if (state.hadException()) {
v8::Local<v8::Value> exception = state.exception();
state.clearException();
- throwError(exception);
+ throwError(exception, args.GetIsolate());
return;
}
v8SetReturnValue(args, result.release(), args.Holder());
@@ -3418,7 +3418,7 @@ static void withScriptExecutionContextAndScriptStateMethod(const v8::FunctionCal
if (state.hadException()) {
v8::Local<v8::Value> exception = state.exception();
state.clearException();
- throwError(exception);
+ throwError(exception, args.GetIsolate());
return;
}
@@ -3447,7 +3447,7 @@ static void withScriptExecutionContextAndScriptStateObjExceptionMethod(const v8:
if (state.hadException()) {
v8::Local<v8::Value> exception = state.exception();
state.clearException();
- throwError(exception);
+ throwError(exception, args.GetIsolate());
return;
}
v8SetReturnValue(args, result.release(), args.Holder());
@@ -3473,7 +3473,7 @@ static void withScriptExecutionContextAndScriptStateWithSpacesMethod(const v8::F
if (state.hadException()) {
v8::Local<v8::Value> exception = state.exception();
state.clearException();
- throwError(exception);
+ throwError(exception, args.GetIsolate());
return;
}
v8SetReturnValue(args, result.release(), args.Holder());

Powered by Google App Engine
This is Rietveld 408576698