Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: Source/bindings/v8/custom/V8IDBAnyCustom.cpp

Issue 24118003: Pass isolate to v8::Undefined() function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8IDBAnyCustom.cpp
diff --git a/Source/bindings/v8/custom/V8IDBAnyCustom.cpp b/Source/bindings/v8/custom/V8IDBAnyCustom.cpp
index 51cbba0226df0a81a707392f9cee08856646cc35..bd23c91875144318da89b4310db376345e3c9b9a 100644
--- a/Source/bindings/v8/custom/V8IDBAnyCustom.cpp
+++ b/Source/bindings/v8/custom/V8IDBAnyCustom.cpp
@@ -55,7 +55,7 @@ static v8::Handle<v8::Value> toV8(const IDBKeyPath& value, v8::Handle<v8::Object
return toV8(keyPaths.release(), creationContext, isolate);
}
ASSERT_NOT_REACHED();
- return v8::Undefined();
+ return v8::Undefined(isolate);
}
v8::Handle<v8::Value> toV8(IDBAny* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
@@ -65,7 +65,7 @@ v8::Handle<v8::Value> toV8(IDBAny* impl, v8::Handle<v8::Object> creationContext,
switch (impl->type()) {
case IDBAny::UndefinedType:
- return v8::Undefined();
+ return v8::Undefined(isolate);
case IDBAny::NullType:
return v8NullWithCheck(isolate);
case IDBAny::DOMStringListType:
@@ -95,7 +95,7 @@ v8::Handle<v8::Value> toV8(IDBAny* impl, v8::Handle<v8::Object> creationContext,
}
ASSERT_NOT_REACHED();
- return v8::Undefined();
+ return v8::Undefined(isolate);
}
} // namespace WebCore
« no previous file with comments | « Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp ('k') | Source/bindings/v8/custom/V8PromiseResolverCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698