Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: Source/bindings/v8/V8ThrowException.cpp

Issue 24118003: Pass isolate to v8::Undefined() function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/V8ThrowException.h ('k') | Source/bindings/v8/WorkerScriptController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8ThrowException.cpp
diff --git a/Source/bindings/v8/V8ThrowException.cpp b/Source/bindings/v8/V8ThrowException.cpp
index 1f303f7cde766660b6bd0dc365fe43a9d6434c88..35aec5561662cc48cb82da8a9b429c1259f6c29a 100644
--- a/Source/bindings/v8/V8ThrowException.cpp
+++ b/Source/bindings/v8/V8ThrowException.cpp
@@ -77,7 +77,7 @@ v8::Handle<v8::Value> V8ThrowException::throwDOMException(int ec, const String&
if (exception.IsEmpty())
return v8Undefined();
- return V8ThrowException::throwError(exception);
+ return V8ThrowException::throwError(exception, isolate);
}
v8::Handle<v8::Value> V8ThrowException::createError(V8ErrorType type, const String& message, v8::Isolate* isolate)
@@ -104,7 +104,7 @@ v8::Handle<v8::Value> V8ThrowException::throwError(V8ErrorType type, const Strin
v8::Handle<v8::Value> exception = V8ThrowException::createError(type, message, isolate);
if (exception.IsEmpty())
return v8Undefined();
- return V8ThrowException::throwError(exception);
+ return V8ThrowException::throwError(exception, isolate);
}
v8::Handle<v8::Value> V8ThrowException::createTypeError(const String& message, v8::Isolate* isolate)
@@ -115,20 +115,20 @@ v8::Handle<v8::Value> V8ThrowException::createTypeError(const String& message, v
v8::Handle<v8::Value> V8ThrowException::throwTypeError(const String& message, v8::Isolate* isolate)
{
v8::Handle<v8::Value> exception = V8ThrowException::createTypeError(message, isolate);
- return V8ThrowException::throwError(exception);
+ return V8ThrowException::throwError(exception, isolate);
}
v8::Handle<v8::Value> V8ThrowException::throwNotEnoughArgumentsError(v8::Isolate* isolate)
{
v8::Handle<v8::Value> exception = V8ThrowException::createTypeError("Not enough arguments", isolate);
- return V8ThrowException::throwError(exception);
+ return V8ThrowException::throwError(exception, isolate);
}
-v8::Handle<v8::Value> V8ThrowException::throwError(v8::Handle<v8::Value> exception)
+v8::Handle<v8::Value> V8ThrowException::throwError(v8::Handle<v8::Value> exception, v8::Isolate* isolate)
{
if (!v8::V8::IsExecutionTerminating())
v8::ThrowException(exception);
- return v8::Undefined();
+ return v8::Undefined(isolate);
}
} // namespace WebCore
« no previous file with comments | « Source/bindings/v8/V8ThrowException.h ('k') | Source/bindings/v8/WorkerScriptController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698