Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: Source/bindings/v8/V8PerContextData.cpp

Issue 24118003: Pass isolate to v8::Undefined() function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/V8Binding.cpp ('k') | Source/bindings/v8/V8ThrowException.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8PerContextData.cpp
diff --git a/Source/bindings/v8/V8PerContextData.cpp b/Source/bindings/v8/V8PerContextData.cpp
index f3ab0b8b5bf6cc642162547e574fd71e08b887bb..5d0c171ce1387357e58d7f307ee7a57b69f958f3 100644
--- a/Source/bindings/v8/V8PerContextData.cpp
+++ b/Source/bindings/v8/V8PerContextData.cpp
@@ -167,7 +167,7 @@ CustomElementBinding* V8PerContextData::customElementBinding(CustomElementDefini
}
-static v8::Handle<v8::Value> createDebugData(const char* worldName, int debugId)
+static v8::Handle<v8::Value> createDebugData(const char* worldName, int debugId, v8::Isolate* isolate)
{
char buffer[32];
unsigned wanted;
@@ -179,8 +179,8 @@ static v8::Handle<v8::Value> createDebugData(const char* worldName, int debugId)
if (wanted < sizeof(buffer))
return v8::String::NewSymbol(buffer);
- return v8::Undefined();
-};
+ return v8::Undefined(isolate);
+}
static v8::Handle<v8::Value> debugData(v8::Handle<v8::Context> context)
{
@@ -199,7 +199,7 @@ bool V8PerContextDebugData::setContextDebugData(v8::Handle<v8::Context> context,
if (!debugData(context)->IsUndefined())
return false;
v8::HandleScope scope(context->GetIsolate());
- v8::Handle<v8::Value> debugData = createDebugData(worldName, debugId);
+ v8::Handle<v8::Value> debugData = createDebugData(worldName, debugId, context->GetIsolate());
setDebugData(context, debugData);
return true;
}
« no previous file with comments | « Source/bindings/v8/V8Binding.cpp ('k') | Source/bindings/v8/V8ThrowException.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698