Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2411583002: bindings: Stop passing ExceptionState to callback function (Closed)

Created:
4 years, 2 months ago by bashi
Modified:
4 years, 1 month ago
Reviewers:
haraken, peria, Yuki
CC:
chromium-reviews, blink-reviews, jsbell+idb_chromium.org, blink-reviews-bindings_chromium.org, cmumford
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Stop passing ExceptionState to callback function At this point we don't need to provide a way to allow user scripts to catch exceptions which are thrown while invoking callback functions. Always passing TrackExceptionState seems redundant so declare it inside auto-generated code. We can restore or add another call() later if we really need it. BUG=653769 Committed: https://crrev.com/4c55631f51b13ae018c6b2f9c6cac9ecc711ed61 Cr-Commit-Position: refs/heads/master@{#424380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -32 lines) Patch
M third_party/WebKit/Source/bindings/scripts/v8_callback_function.py View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongExperimentalCallbackFunction.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongExperimentalCallbackFunction.cpp View 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp View 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp View 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidExperimentalCallbackFunction.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidExperimentalCallbackFunction.cpp View 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp View 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp View 4 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceObserver.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
bashi
PTAL
4 years, 2 months ago (2016-10-11 05:16:03 UTC) #4
haraken
LGTM
4 years, 2 months ago (2016-10-11 05:17:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411583002/1
4 years, 2 months ago (2016-10-11 06:42:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 06:46:58 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 06:48:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c55631f51b13ae018c6b2f9c6cac9ecc711ed61
Cr-Commit-Position: refs/heads/master@{#424380}

Powered by Google App Engine
This is Rietveld 408576698