Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp

Issue 2411583002: bindings: Stop passing ExceptionState to callback function (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/timing/PerformanceObserver.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp
index 88ea10eb6f41547522b4750fe40a3405a1d5108c..95abf13fd943670ef41e1446a317e32a75b242fe 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp
@@ -102,11 +102,8 @@ void IDBObserver::onChange(int32_t id,
const WebVector<int32_t>& observationIndex) {
auto it = m_observerIds.find(id);
DCHECK(it != m_observerIds.end());
- // TODO(bashi): Make sure that using TrackExceptionState is OK.
- // crbug.com/653769
- TrackExceptionState exceptionState;
m_callback->call(
- m_scriptState.get(), this, exceptionState,
+ m_scriptState.get(), this,
IDBObserverChanges::create(it->value, observations, observationIndex));
}
« no previous file with comments | « third_party/WebKit/Source/core/timing/PerformanceObserver.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698