Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/LongExperimentalCallbackFunction.cpp

Issue 2411583002: bindings: Stop passing ExceptionState to callback function (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/LongExperimentalCallbackFunction.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/LongExperimentalCallbackFunction.cpp b/third_party/WebKit/Source/bindings/tests/results/core/LongExperimentalCallbackFunction.cpp
index 7d240afd1925419748e267d60d7f2fe8f2193969..1dab12e47337583760fd8fc935158df192129193 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/LongExperimentalCallbackFunction.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/LongExperimentalCallbackFunction.cpp
@@ -8,6 +8,7 @@
#include "LongExperimentalCallbackFunction.h"
+#include "bindings/core/v8/ExceptionState.h"
#include "bindings/core/v8/ScriptState.h"
#include "bindings/core/v8/ToV8.h"
#include "bindings/core/v8/V8Binding.h"
@@ -27,7 +28,7 @@ DEFINE_TRACE(LongExperimentalCallbackFunction)
{
}
-bool LongExperimentalCallbackFunction::call(ScriptState* scriptState, ScriptWrappable* scriptWrappable, ExceptionState& exceptionState, int num1, int num2, int& returnValue)
+bool LongExperimentalCallbackFunction::call(ScriptState* scriptState, ScriptWrappable* scriptWrappable, int num1, int num2, int& returnValue)
{
if (!scriptState->contextIsValid())
return false;
@@ -40,6 +41,9 @@ bool LongExperimentalCallbackFunction::call(ScriptState* scriptState, ScriptWrap
if (m_callback.isEmpty())
return false;
+ // TODO(bashi): Make sure that using TrackExceptionState is OK.
+ // crbug.com/653769
+ TrackExceptionState exceptionState;
ScriptState::Scope scope(scriptState);
v8::Local<v8::Value> num1Argument = v8::Integer::New(scriptState->isolate(), num1);

Powered by Google App Engine
This is Rietveld 408576698