third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h - Issue 2411583002: bindings: Stop passing ExceptionState to callback function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h

Issue 2411583002: bindings: Stop passing ExceptionState to callback function (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/VoidExperimentalCallbackFunction.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h b/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h

index 2d0696f34a4d02ac24137b7a3695f9ffbeb1f130..1bf6a3e353a56b9871d5627cbf915952bf0cf6a5 100644

--- a/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h

+++ b/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h

@@ -9,7 +9,6 @@

#ifndef VoidCallbackFunctionModules_h

#define VoidCallbackFunctionModules_h

-#include "bindings/core/v8/ExceptionState.h"

#include "bindings/core/v8/ScopedPersistent.h"

#include "modules/ModulesExport.h"

#include "platform/heap/Handle.h"

@@ -30,7 +29,7 @@ public:

DECLARE_TRACE();

- bool call(ScriptState* scriptState, ScriptWrappable* scriptWrappable, ExceptionState& exceptionState);

+ bool call(ScriptState* scriptState, ScriptWrappable* scriptWrappable);

v8::Local<v8::Function> v8Value(v8::Isolate* isolate)

{