Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp

Issue 2411583002: bindings: Stop passing ExceptionState to callback function (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp
diff --git a/third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp b/third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp
index 8662dd343006f1bb87225ad0b990cf32516dde8d..17e3770861d90ca4c1b3629ada5789083b8f4a24 100644
--- a/third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp
+++ b/third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp
@@ -24,8 +24,8 @@ String CallbackFunctionTest::testCallback(ScriptState* scriptState,
ScriptWrappable* scriptWrappable;
String returnValue;
- if (callback->call(scriptState, scriptWrappable = nullptr, exceptionState,
- message1, message2, returnValue)) {
+ if (callback->call(scriptState, scriptWrappable = nullptr, message1, message2,
+ returnValue)) {
return String("SUCCESS: ") + returnValue;
}
return String("Error!");
@@ -38,8 +38,7 @@ void CallbackFunctionTest::testInterfaceCallback(
ExceptionState& exceptionState) {
ScriptWrappable* scriptWrappable;
- callback->call(scriptState, scriptWrappable = nullptr, exceptionState,
- divElement);
+ callback->call(scriptState, scriptWrappable = nullptr, divElement);
return;
}
@@ -47,7 +46,7 @@ void CallbackFunctionTest::testReceiverObjectCallback(
ScriptState* scriptState,
TestReceiverObjectCallback* callback,
ExceptionState& exceptionState) {
- callback->call(scriptState, this, exceptionState);
+ callback->call(scriptState, this);
return;
}
@@ -57,8 +56,7 @@ Vector<String> CallbackFunctionTest::testSequenceCallback(
const Vector<int>& numbers,
ExceptionState& exceptionState) {
Vector<String> returnValue;
- if (callback->call(scriptState, nullptr, exceptionState, numbers,
- returnValue)) {
+ if (callback->call(scriptState, nullptr, numbers, returnValue)) {
return returnValue;
}
return Vector<String>();

Powered by Google App Engine
This is Rietveld 408576698