Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_callback_function.py

Issue 2411583002: bindings: Stop passing ExceptionState to callback function (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/scripts/v8_callback_function.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py b/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py
index 365d9939a8a5e7e040c8032be5c341a4666c61fc..d3c2e6f98d37b9c9bce603ab630e1d3684cacb08 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py
@@ -11,12 +11,12 @@ from v8_globals import includes # pylint: disable=W0403
import v8_utilities # pylint: disable=W0403
CALLBACK_FUNCTION_H_INCLUDES = frozenset([
- 'bindings/core/v8/ExceptionState.h',
'bindings/core/v8/ScopedPersistent.h',
'platform/heap/Handle.h',
'wtf/text/WTFString.h',
])
CALLBACK_FUNCTION_CPP_INCLUDES = frozenset([
+ 'bindings/core/v8/ExceptionState.h',
'bindings/core/v8/ScriptState.h',
'bindings/core/v8/ToV8.h',
'bindings/core/v8/V8Binding.h',
@@ -69,7 +69,6 @@ def arguments_context(arguments, return_cpp_type):
argument_declarations = [
'ScriptState* scriptState',
'ScriptWrappable* scriptWrappable',
- 'ExceptionState& exceptionState',
]
argument_declarations.extend(
'%s %s' % (argument.idl_type.callback_cpp_type, argument.name)
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698