Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp

Issue 2411583002: bindings: Stop passing ExceptionState to callback function (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp b/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp
index 145068f2243e3db9561e421f43e97ef0b1b2b1b1..c60500222e8be5f02669f575088131d755fe1825 100644
--- a/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp
@@ -8,6 +8,7 @@
#include "VoidCallbackFunctionModules.h"
+#include "bindings/core/v8/ExceptionState.h"
#include "bindings/core/v8/ScriptState.h"
#include "bindings/core/v8/ToV8.h"
#include "bindings/core/v8/V8Binding.h"
@@ -27,7 +28,7 @@ DEFINE_TRACE(VoidCallbackFunctionModules)
{
}
-bool VoidCallbackFunctionModules::call(ScriptState* scriptState, ScriptWrappable* scriptWrappable, ExceptionState& exceptionState)
+bool VoidCallbackFunctionModules::call(ScriptState* scriptState, ScriptWrappable* scriptWrappable)
{
if (!scriptState->contextIsValid())
return false;
@@ -40,6 +41,9 @@ bool VoidCallbackFunctionModules::call(ScriptState* scriptState, ScriptWrappable
if (m_callback.isEmpty())
return false;
+ // TODO(bashi): Make sure that using TrackExceptionState is OK.
+ // crbug.com/653769
+ TrackExceptionState exceptionState;
ScriptState::Scope scope(scriptState);
v8::Local<v8::Value> thisValue = toV8(scriptWrappable, scriptState->context()->Global(), scriptState->isolate());

Powered by Google App Engine
This is Rietveld 408576698