third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl - Issue 2411583002: bindings: Stop passing ExceptionState to callback function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

Issue 2411583002: bindings: Stop passing ExceptionState to callback function (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_callback_function.py ('k') | third_party/WebKit/Source/bindings/tests/results/core/LongExperimentalCallbackFunction.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

index f16b6391f4cb510c15015b81526d87df6604768c..ecf618e362ab4a4ebc7ca4369ceabf67c2288b65 100644

--- a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

@@ -35,6 +35,9 @@ bool {{cpp_class}}::call({{argument_declarations | join(', ')}})

if (m_callback.isEmpty())

return false;

+ // TODO(bashi): Make sure that using TrackExceptionState is OK.

+ // crbug.com/653769

+ TrackExceptionState exceptionState;

ScriptState::Scope scope(scriptState);

{% for argument in arguments %}