[Sync] Fixing easy lint violations.

[Sync] Fixing easy lint violations.

BUG=

Committed: https://crrev.com/6d5ecf800a6776d0a58443c323d7c6abcd404a4a
Cr-Commit-Position: refs/heads/master@{#422851}

[skym, 2016-10-03 23:43:07]

Description was changed from

==========
[Sync] Fixing easy lint violations.

BUG=
==========

to

==========
[Sync] Fixing easy lint violations.

BUG=
==========

[skym, 2016-10-03 23:43:07]

skym@chromium.org changed reviewers:
+ maxbogue@chromium.org

[skym, 2016-10-03 23:46:10]

The command I ran to find lint violations are as follows, with the still
outstanding errors listed

> find components/sync components/browser_sync components/sync_sessions
components/sync_bookmarks chrome/browser/sync | grep "\.cc$\|\.h$" | xargs
../../depot_tools/cpplint.py  2>&1 | grep -v "Done processing"

components/sync/api/entity_data.cc:57:  Extra space before ) 
[whitespace/parens] [2]
components/sync/api/entity_data.cc:58:  Extra space before ) 
[whitespace/parens] [2]
components/sync/api/entity_data.cc:59:  Extra space before ) 
[whitespace/parens] [2]
components/sync/api/entity_data.cc:60:  Extra space before ) 
[whitespace/parens] [2]
components/sync/base/unique_position_unittest.cc:73:  For a static/global string
constant, use a C style string instead: "const char kMinSuffix[]". 
[runtime/string] [4]
components/sync/base/bind_to_task_runner.h:40:  Is this a non-const reference?
If so, make const or use a pointer: T& t  [runtime/references] [2]
components/sync/base/bind_to_task_runner.h:46:  Is this a non-const reference?
If so, make const or use a pointer: std::unique_ptr<T, R>& p 
[runtime/references] [2]
Total errors found: 7

[skym, 2016-10-03 23:46:12]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[skym, 2016-10-03 23:46:20]

PTAL

[commit-bot: I haz the power, 2016-10-03 23:46:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-10-04 00:11:51]

lgtm w/ one question! Awesome dude.

https://codereview.chromium.org/2389063002/diff/1/components/sync/syncable/di...
File components/sync/syncable/directory_backing_store.cc (left):

https://codereview.chromium.org/2389063002/diff/1/components/sync/syncable/di...
components/sync/syncable/directory_backing_store.cc:238: const
int(&entries_counts)[MODEL_TYPE_COUNT]) {
Wat. Was this previously accepting a reference to the array? Wouldn't you be
copying the array now? The parens don't seem necessary though...

[commit-bot: I haz the power, 2016-10-04 02:12:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 02:12:44]

Dry run: This issue passed the CQ dry run.

[skym, 2016-10-04 15:57:36]

https://codereview.chromium.org/2389063002/diff/1/components/sync/syncable/di...
File components/sync/syncable/directory_backing_store.cc (left):

https://codereview.chromium.org/2389063002/diff/1/components/sync/syncable/di...
components/sync/syncable/directory_backing_store.cc:238: const
int(&entries_counts)[MODEL_TYPE_COUNT]) {
On 2016/10/04 00:11:51, maxbogue wrote:
> Wat. Was this previously accepting a reference to the array? Wouldn't you be
> copying the array now? The parens don't seem necessary though...

Whoops, okay after Googling to try to better explain to you why this is safe, it
turns out it is not, reverting.

So, I looked up yesterday how to pass an array by reference, and it seemed that
arrays were always passed by reference, so I was like, great, lets remove this
funky syntax.

Googling again though
http://stackoverflow.com/questions/5724171/passing-an-array-by-reference/5724...
, it looks like the size gets ignored with the syntax I moved to. So back to the
original.

However, it seems if I just add a space between "int" and "(&entries_count)" we
dodge the lint complaint. Yay!

[maxbogue, 2016-10-04 16:24:45]

https://codereview.chromium.org/2389063002/diff/1/components/sync/syncable/di...
File components/sync/syncable/directory_backing_store.cc (left):

https://codereview.chromium.org/2389063002/diff/1/components/sync/syncable/di...
components/sync/syncable/directory_backing_store.cc:238: const
int(&entries_counts)[MODEL_TYPE_COUNT]) {
On 2016/10/04 15:57:35, skym wrote:
> On 2016/10/04 00:11:51, maxbogue wrote:
> > Wat. Was this previously accepting a reference to the array? Wouldn't you be
> > copying the array now? The parens don't seem necessary though...
> 
> Whoops, okay after Googling to try to better explain to you why this is safe,
it
> turns out it is not, reverting.
> 
> So, I looked up yesterday how to pass an array by reference, and it seemed
that
> arrays were always passed by reference, so I was like, great, lets remove this
> funky syntax.
> 
> Googling again though
>
http://stackoverflow.com/questions/5724171/passing-an-array-by-reference/5724...
> , it looks like the size gets ignored with the syntax I moved to. So back to
the
> original.
> 
> However, it seems if I just add a space between "int" and "(&entries_count)"
we
> dodge the lint complaint. Yay!

Ah, cool!

[skym, 2016-10-04 16:50:17]

The CQ bit was checked by skym@chromium.org

[skym, 2016-10-04 16:50:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org
Link to the patchset: https://codereview.chromium.org/2389063002/#ps20001
(title: "Updated for Max's comments.")

[commit-bot: I haz the power, 2016-10-04 16:50:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 17:44:40]

Description was changed from

==========
[Sync] Fixing easy lint violations.

BUG=
==========

to

==========
[Sync] Fixing easy lint violations.

BUG=
==========

[commit-bot: I haz the power, 2016-10-04 17:44:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-04 17:48:22]

Description was changed from

==========
[Sync] Fixing easy lint violations.

BUG=
==========

to

==========
[Sync] Fixing easy lint violations.

BUG=

Committed: https://crrev.com/6d5ecf800a6776d0a58443c323d7c6abcd404a4a
Cr-Commit-Position: refs/heads/master@{#422851}
==========

[commit-bot: I haz the power, 2016-10-04 17:48:23]

Patchset 2 (id:??) landed as
https://crrev.com/6d5ecf800a6776d0a58443c323d7c6abcd404a4a
Cr-Commit-Position: refs/heads/master@{#422851}