Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: components/sync_sessions/revisit/current_tab_matcher_unittest.cc

Issue 2389063002: [Sync] Fixing easy lint violations. (Closed)
Patch Set: Updated for Max's comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync_sessions/revisit/current_tab_matcher.h" 5 #include "components/sync_sessions/revisit/current_tab_matcher.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 9
10 #include "base/test/histogram_tester.h" 10 #include "base/test/histogram_tester.h"
11 #include "base/time/time.h" 11 #include "base/time/time.h"
12 #include "components/sessions/core/serialized_navigation_entry.h" 12 #include "components/sessions/core/serialized_navigation_entry.h"
13 #include "components/sessions/core/serialized_navigation_entry_test_helper.h" 13 #include "components/sessions/core/serialized_navigation_entry_test_helper.h"
14 #include "components/sessions/core/session_types.h" 14 #include "components/sessions/core/session_types.h"
15 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
16 #include "url/gurl.h" 16 #include "url/gurl.h"
17 17
18 using sessions::SessionTab; 18 using sessions::SessionTab;
19 19
20 namespace sync_sessions { 20 namespace sync_sessions {
21 21
22 namespace { 22 namespace {
23 23
24 static const std::string kExampleUrl = "http://www.example.com"; 24 const char kExampleUrl[] = "http://www.example.com";
25 static const std::string kDifferentUrl = "http://www.different.com"; 25 const char kDifferentUrl[] = "http://www.different.com";
26 26
27 sessions::SerializedNavigationEntry Entry(const std::string& url) { 27 sessions::SerializedNavigationEntry Entry(const std::string& url) {
28 return sessions::SerializedNavigationEntryTestHelper::CreateNavigation(url, 28 return sessions::SerializedNavigationEntryTestHelper::CreateNavigation(url,
29 ""); 29 "");
30 } 30 }
31 31
32 std::unique_ptr<SessionTab> Tab(const int index, const base::Time timestamp) { 32 std::unique_ptr<SessionTab> Tab(const int index, const base::Time timestamp) {
33 std::unique_ptr<SessionTab> tab(new SessionTab()); 33 std::unique_ptr<SessionTab> tab(new SessionTab());
34 tab->current_navigation_index = index; 34 tab->current_navigation_index = index;
35 tab->timestamp = timestamp; 35 tab->timestamp = timestamp;
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 ASSERT_EQ(tab2.get(), matcher1.most_recent_match_); 106 ASSERT_EQ(tab2.get(), matcher1.most_recent_match_);
107 107
108 // Now repeat the same test but check the tabs in the opposite order. 108 // Now repeat the same test but check the tabs in the opposite order.
109 CurrentTabMatcher matcher2((PageEquality(GURL(kExampleUrl)))); 109 CurrentTabMatcher matcher2((PageEquality(GURL(kExampleUrl))));
110 matcher2.Check(tab2.get()); 110 matcher2.Check(tab2.get());
111 matcher2.Check(tab1.get()); 111 matcher2.Check(tab1.get());
112 ASSERT_EQ(tab2.get(), matcher2.most_recent_match_); 112 ASSERT_EQ(tab2.get(), matcher2.most_recent_match_);
113 } 113 }
114 114
115 } // namespace sync_sessions 115 } // namespace sync_sessions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698