Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: chrome/browser/sync/chrome_sync_client_unittest.cc

Issue 2389063002: [Sync] Fixing easy lint violations. (Closed)
Patch Set: Updated for Max's comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/glue/extensions_activity_monitor_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/chrome_sync_client.h" 5 #include "chrome/browser/sync/chrome_sync_client.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string>
8 9
9 #include "chrome/common/url_constants.h" 10 #include "chrome/common/url_constants.h"
10 #include "components/sync/driver/sync_api_component_factory.h" 11 #include "components/sync/driver/sync_api_component_factory.h"
11 #include "components/sync_sessions/sync_sessions_client.h" 12 #include "components/sync_sessions/sync_sessions_client.h"
12 #include "content/public/test/test_browser_thread_bundle.h" 13 #include "content/public/test/test_browser_thread_bundle.h"
13 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
14 #include "url/gurl.h" 15 #include "url/gurl.h"
15 16
16 namespace browser_sync { 17 namespace browser_sync {
17 18
18 namespace { 19 namespace {
19 20
20 const std::string kValidUrl = "http://www.example.com"; 21 const char kValidUrl[] = "http://www.example.com";
21 const std::string kInvalidUrl = "invalid.url"; 22 const char kInvalidUrl[] = "invalid.url";
22 23
23 class ChromeSyncClientTest : public testing::Test { 24 class ChromeSyncClientTest : public testing::Test {
24 public: 25 public:
25 ChromeSyncClientTest() 26 ChromeSyncClientTest()
26 : sync_client_(new ChromeSyncClient(nullptr, nullptr)) {} 27 : sync_client_(new ChromeSyncClient(nullptr, nullptr)) {}
27 ~ChromeSyncClientTest() override {} 28 ~ChromeSyncClientTest() override {}
28 29
29 ChromeSyncClient* sync_client() { return sync_client_.get(); } 30 ChromeSyncClient* sync_client() { return sync_client_.get(); }
30 31
31 private: 32 private:
(...skipping 18 matching lines...) Expand all
50 EXPECT_FALSE(sync_client()->GetSyncSessionsClient()->ShouldSyncURL( 51 EXPECT_FALSE(sync_client()->GetSyncSessionsClient()->ShouldSyncURL(
51 GURL("chrome-native://anything"))); 52 GURL("chrome-native://anything")));
52 53
53 EXPECT_TRUE(sync_client()->GetSyncSessionsClient()->ShouldSyncURL( 54 EXPECT_TRUE(sync_client()->GetSyncSessionsClient()->ShouldSyncURL(
54 GURL(chrome::kChromeUIHistoryURL))); 55 GURL(chrome::kChromeUIHistoryURL)));
55 } 56 }
56 57
57 } // namespace 58 } // namespace
58 59
59 } // namespace browser_sync 60 } // namespace browser_sync
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/sync/glue/extensions_activity_monitor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698