Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issue 2388973002: [Sync] Removing duplicate includes, part 2. (Closed)

Created:
4 years, 2 months ago by skym
Modified:
4 years, 2 months ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Removing duplicate includes, part 2. This time the header lookup uses the first include. BUG= Committed: https://crrev.com/f4b335b9db7242fdc589ffacfc75744b6e93656b Cr-Commit-Position: refs/heads/master@{#422826}

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 2

Patch Set 3 : Update for Max's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -1917 lines) Patch
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/sync_global_error_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M components/browser_sync/profile_sync_service.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/browser_sync/profile_sync_service.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/browser_sync/profile_sync_service_startup_unittest.cc View 1 2 chunks +1 line, -7 lines 0 comments Download
M components/browser_sync/profile_sync_service_unittest.cc View 1 2 3 chunks +0 lines, -9 lines 0 comments Download
M components/sync/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/api/attachments/attachment_metadata_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/api/attachments/attachment_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/sync/api/model_type_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/sync/api/sync_change_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/api/sync_data_unittest.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M components/sync/api/sync_error_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/base/cryptographer_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/base/data_type_histogram_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/base/get_session_name_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/base/immutable_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/sync/base/model_type_test_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/base/nigori_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/base/node_ordinal_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/base/ordinal_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/sync/base/unique_position_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/sync/base/weak_handle_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/sync/core/change_record_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/sync/core/http_bridge_unittest.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M components/sync/core/processor_entity_tracker_unittest.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M components/sync/core/shared_model_type_processor_unittest.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M components/sync/core_impl/attachments/attachment_downloader.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/core_impl/attachments/attachment_downloader_impl.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/sync/core_impl/attachments/attachment_downloader_impl_unittest.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M components/sync/core_impl/attachments/attachment_service_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/core_impl/attachments/attachment_service_impl_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/core_impl/attachments/attachment_service_proxy_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/core_impl/attachments/attachment_store_frontend_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/core_impl/attachments/attachment_uploader_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M components/sync/core_impl/attachments/attachment_uploader_impl_unittest.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M components/sync/core_impl/attachments/attachment_util.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/core_impl/attachments/on_disk_attachment_store.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/core_impl/attachments/on_disk_attachment_store_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/core_impl/attachments/task_queue_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/sync/core_impl/js_mutation_event_observer_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/core_impl/js_sync_encryption_handler_observer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/core_impl/js_sync_manager_observer_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/core_impl/model_type_connector_proxy_unittest.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M components/sync/core_impl/protocol_event_buffer_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/sync/core_impl/sync_encryption_handler_impl_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/core_impl/sync_manager_impl_unittest.cc View 1 3 chunks +0 lines, -7 lines 0 comments Download
M components/sync/core_impl/syncapi_server_connection_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/core_impl/test/test_entry_factory.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/core_impl/test/test_user_share.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/device_info/device_count_metrics_provider_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/device_info/device_info_service_unittest.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M components/sync/device_info/device_info_sync_service_unittest.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M components/sync/device_info/device_info_util_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
A + components/sync/device_info/local_device_info_provider_impl_unittest.cc View 1 8 chunks +11 lines, -11 lines 0 comments Download
D components/sync/device_info/local_device_info_provider_unittest.cc View 1 1 chunk +0 lines, -143 lines 0 comments Download
M components/sync/driver/about_sync_util_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/driver/data_type_manager_impl_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/driver/data_type_manager_mock.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/driver/frontend_data_type_controller_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/driver/generic_change_processor_unittest.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl_unittest.cc View 1 3 chunks +0 lines, -7 lines 0 comments Download
M components/sync/driver/glue/sync_backend_registrar_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/driver/glue/ui_model_worker_unittest.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M components/sync/driver/non_blocking_data_type_controller_unittest.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M components/sync/driver/non_ui_data_type_controller_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/driver/shared_change_processor_unittest.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M components/sync/driver/startup_controller_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/driver/sync_prefs_unittest.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M components/sync/driver/sync_stopped_reporter_unittest.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M components/sync/driver/system_encryptor_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/driver/ui_data_type_controller_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/engine/cycle/sync_cycle_snapshot_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/engine/model_safe_worker_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/engine_impl/backoff_delay_provider_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/engine_impl/cycle/nudge_tracker_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/engine_impl/directory_commit_contribution_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/sync/engine_impl/directory_update_handler_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/sync/engine_impl/get_updates_processor_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M components/sync/engine_impl/model_type_registry_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/engine_impl/model_type_worker_unittest.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M components/sync/engine_impl/sync_scheduler_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/engine_impl/sync_scheduler_impl_unittest.cc View 45 chunks +49 lines, -51 lines 0 comments Download
D components/sync/engine_impl/sync_scheduler_unittest.cc View 1 chunk +0 lines, -1438 lines 0 comments Download
M components/sync/engine_impl/syncer_proto_util_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/sync/engine_impl/syncer_unittest.cc View 1 3 chunks +0 lines, -5 lines 0 comments Download
M components/sync/engine_impl/syncer_util_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/sync/engine_impl/worker_entity_tracker_unittest.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M components/sync/protocol/proto_value_conversions_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/syncable/directory_backing_store_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/sync/syncable/parent_child_index_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync_sessions/favicon_cache_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/sync_sessions/lost_navigations_recorder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync_sessions/lost_navigations_recorder_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync_sessions/revisit/bookmarks_page_revisit_observer_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/sync_sessions/revisit/current_tab_matcher_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync_sessions/revisit/offset_tab_matcher_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync_sessions/revisit/page_revisit_broadcaster_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M components/sync_sessions/revisit/typed_url_page_revisit_task_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/sync_sessions/synced_session_tracker_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/sync_sessions/tab_node_pool_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (12 generated)
skym
PTAL
4 years, 2 months ago (2016-10-03 23:40:08 UTC) #7
skym
Adding Max for real this time, PTAL.
4 years, 2 months ago (2016-10-03 23:40:52 UTC) #9
maxbogue
lgtm, awesome cleanup! Just one little nit. https://codereview.chromium.org/2388973002/diff/20001/components/browser_sync/profile_sync_service_startup_unittest.cc File components/browser_sync/profile_sync_service_startup_unittest.cc (left): https://codereview.chromium.org/2388973002/diff/20001/components/browser_sync/profile_sync_service_startup_unittest.cc#oldcode6 components/browser_sync/profile_sync_service_startup_unittest.cc:6: #include <utility> ...
4 years, 2 months ago (2016-10-04 00:28:52 UTC) #12
skym
https://codereview.chromium.org/2388973002/diff/20001/components/browser_sync/profile_sync_service_startup_unittest.cc File components/browser_sync/profile_sync_service_startup_unittest.cc (left): https://codereview.chromium.org/2388973002/diff/20001/components/browser_sync/profile_sync_service_startup_unittest.cc#oldcode6 components/browser_sync/profile_sync_service_startup_unittest.cc:6: #include <utility> On 2016/10/04 00:28:52, maxbogue wrote: > profile_sync_service.h ...
4 years, 2 months ago (2016-10-04 15:49:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388973002/40001
4 years, 2 months ago (2016-10-04 15:50:23 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-04 16:40:21 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 16:42:14 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f4b335b9db7242fdc589ffacfc75744b6e93656b
Cr-Commit-Position: refs/heads/master@{#422826}

Powered by Google App Engine
This is Rietveld 408576698