Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: components/sync/test/fake_server/bookmark_entity.cc

Issue 2389063002: [Sync] Fixing easy lint violations. (Closed)
Patch Set: Updated for Max's comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/test/fake_server/bookmark_entity.cc
diff --git a/components/sync/test/fake_server/bookmark_entity.cc b/components/sync/test/fake_server/bookmark_entity.cc
index 9fca61f91c387c74cfd787b1d1a3172d6075da17..a301a31b222a6d7f0031a5a5302ca93b824c9111 100644
--- a/components/sync/test/fake_server/bookmark_entity.cc
+++ b/components/sync/test/fake_server/bookmark_entity.cc
@@ -25,7 +25,7 @@ std::unique_ptr<FakeServerEntity> BookmarkEntity::CreateNew(
const sync_pb::SyncEntity& client_entity,
const string& parent_id,
const string& client_guid) {
- CHECK(client_entity.version() == 0) << "New entities must have version = 0.";
+ CHECK_EQ(0, client_entity.version()) << "New entities must have version = 0.";
CHECK(IsBookmark(client_entity)) << "The given entity must be a bookmark.";
const string id =
@@ -45,8 +45,8 @@ std::unique_ptr<FakeServerEntity> BookmarkEntity::CreateUpdatedVersion(
const sync_pb::SyncEntity& client_entity,
const FakeServerEntity& current_server_entity,
const string& parent_id) {
- CHECK(client_entity.version() != 0) << "Existing entities must not have a "
- << "version = 0.";
+ CHECK_NE(0, client_entity.version()) << "Existing entities must not have a "
+ << "version = 0.";
CHECK(IsBookmark(client_entity)) << "The given entity must be a bookmark.";
const BookmarkEntity& current_bookmark_entity =
« no previous file with comments | « components/sync/test/fake_server/bookmark_entity.h ('k') | components/sync/test/fake_server/permanent_entity.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698