components/sync/engine_impl/commit.cc - Issue 2389063002: [Sync] Fixing easy lint violations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/sync/engine_impl/commit.cc

Issue 2389063002: [Sync] Fixing easy lint violations. (Closed)

Patch Set: Updated for Max's comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/sync/engine/cycle/sync_cycle_snapshot.cc ('k') | components/sync/engine_impl/commit_processor.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2012 The Chromium Authors. All rights reserved.	1 // Copyright 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/sync/engine_impl/commit.h"	5 #include "components/sync/engine_impl/commit.h"

6	6

	7 #include <utility>

	8

7 #include "base/metrics/sparse_histogram.h"	9 #include "base/metrics/sparse_histogram.h"

8 #include "base/trace_event/trace_event.h"	10 #include "base/trace_event/trace_event.h"

9 #include "components/sync/base/data_type_histogram.h"	11 #include "components/sync/base/data_type_histogram.h"

10 #include "components/sync/engine/events/commit_request_event.h"	12 #include "components/sync/engine/events/commit_request_event.h"

11 #include "components/sync/engine/events/commit_response_event.h"	13 #include "components/sync/engine/events/commit_response_event.h"

12 #include "components/sync/engine_impl/commit_processor.h"	14 #include "components/sync/engine_impl/commit_processor.h"

13 #include "components/sync/engine_impl/commit_util.h"	15 #include "components/sync/engine_impl/commit_util.h"

14 #include "components/sync/engine_impl/cycle/sync_cycle.h"	16 #include "components/sync/engine_impl/cycle/sync_cycle.h"

15 #include "components/sync/engine_impl/syncer.h"	17 #include "components/sync/engine_impl/syncer.h"

16 #include "components/sync/engine_impl/syncer_proto_util.h"	18 #include "components/sync/engine_impl/syncer_proto_util.h"

(...skipping 156 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
173	175

174 void Commit::CleanUp() {	176 void Commit::CleanUp() {

175 for (ContributionMap::const_iterator it = contributions_.begin();	177 for (ContributionMap::const_iterator it = contributions_.begin();

176 it != contributions_.end(); ++it) {	178 it != contributions_.end(); ++it) {

177 it->second->CleanUp();	179 it->second->CleanUp();

178 }	180 }

179 cleaned_up_ = true;	181 cleaned_up_ = true;

180 }	182 }

181	183

182 } // namespace syncer	184 } // namespace syncer

OLD	NEW