Implement WEBGL_compressed_texture_es3_0 extension for WebGL 1/2

Implement WEBGL_compressed_texture_es3_0 extension for WebGL 1/2

BUG=455568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/993c5239d057144c1473d62cef9e45b2e1903174
Cr-Commit-Position: refs/heads/master@{#420271}

[Kai Ninomiya, 2016-09-19 22:25:01]

Description was changed from

==========
Implement WEBGL_compressed_texture_es3_0 extension for WebGL 1/2

BUG=455568
==========

to

==========
Implement WEBGL_compressed_texture_es3_0 extension for WebGL 1/2

BUG=455568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-09-19 22:25:02]

Description was changed from

==========
Implement WEBGL_compressed_texture_es3_0 extension for WebGL 1/2

BUG=455568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Implement WEBGL_compressed_texture_es3_0 extension for WebGL 1/2

BUG=455568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-09-19 22:31:12]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 22:32:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 23:02:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 23:02:55]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Kai Ninomiya, 2016-09-20 01:25:03]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 01:25:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 02:52:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 02:52:54]

Dry run: This issue passed the CQ dry run.

[Kai Ninomiya, 2016-09-20 17:46:05]

kainino@chromium.org changed reviewers:
+ haraken@chromium.org, kbr@chromium.org

[Kai Ninomiya, 2016-09-20 17:46:06]

PTAL

(haraken: modules_idl_files.gni only)

[Ken Russell (switch to Gerrit), 2016-09-21 00:16:07]

This looks good overall. One comment about the command buffer code.

zmo, piman: FYI.

https://codereview.chromium.org/2354713004/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2354713004/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:1020: GL_COMPRESSED_R11_EAC);
I think we need to be careful about whether these values have already been
added. If the context type is WebGL 2.0 or ES 3.0 then
FeatureInfo::EnableES3Validators will add these. See its call in
GLES2DecoderImpl::Initialize.

Let's refactor this code and add a
FeatureInfo::EnableES3CompressedTextureFormats to avoid duplicating code. Could
you modify src/gpu/command_buffer/build_gles2_cmd_buffer.py and have it generate
a Validators::UpdateES3CompressedTextureFormats which is called by
Validators::UpdateValuesES3?

[Kai Ninomiya, 2016-09-21 22:31:17]

kbr: Updated

https://codereview.chromium.org/2354713004/diff/60001/gpu/command_buffer/comm...
File gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h (right):

https://codereview.chromium.org/2354713004/diff/60001/gpu/command_buffer/comm...
gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h:3635: return
GLES2Util::GetQualifiedEnumString(NULL, 0, value);
Is this change in the autogenerated code okay?

https://codereview.chromium.org/2354713004/diff/60001/gpu/command_buffer/comm...
gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h:4718: };
And this one?

[Kai Ninomiya, 2016-09-21 22:46:47]

Updated again, ignore previous comments

https://codereview.chromium.org/2354713004/diff/60001/gpu/command_buffer/comm...
File gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h (right):

https://codereview.chromium.org/2354713004/diff/60001/gpu/command_buffer/comm...
gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h:3635: return
GLES2Util::GetQualifiedEnumString(NULL, 0, value);
On 2016/09/21 22:31:17, Kai Ninomiya wrote:
> Is this change in the autogenerated code okay?

Never mind, once my brain started working again I realized this probably didn't
make sense.

https://codereview.chromium.org/2354713004/diff/60001/gpu/command_buffer/comm...
gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h:4718: };
On 2016/09/21 22:31:17, Kai Ninomiya wrote:
> And this one?

Never mind

[Ken Russell (switch to Gerrit), 2016-09-21 23:15:46]

This looks excellent. LGTM

[Ken Russell (switch to Gerrit), 2016-09-21 23:16:05]

Let's ask zmo@ if he would like to review, otherwise we'll TBR= it to haraken
and CQ it now.

[Zhenyao Mo, 2016-09-21 23:17:46]

On 2016/09/21 23:16:05, Ken Russell wrote:
> Let's ask zmo@ if he would like to review, otherwise we'll TBR= it to haraken
> and CQ it now.

lgtm

[Ken Russell (switch to Gerrit), 2016-09-21 23:31:02]

Description was changed from

==========
Implement WEBGL_compressed_texture_es3_0 extension for WebGL 1/2

BUG=455568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement WEBGL_compressed_texture_es3_0 extension for WebGL 1/2

BUG=455568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=haraken@chromium.org
==========

[Ken Russell (switch to Gerrit), 2016-09-21 23:31:15]

TBR'ing haraken for modules_idl_files.gni change.

[Ken Russell (switch to Gerrit), 2016-09-21 23:31:20]

The CQ bit was checked by kbr@chromium.org

[Kai Ninomiya, 2016-09-21 23:32:28]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 23:32:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-09-22 00:50:00]

modules/ LGTM

[Kai Ninomiya, 2016-09-22 00:50:25]

Description was changed from

==========
Implement WEBGL_compressed_texture_es3_0 extension for WebGL 1/2

BUG=455568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=haraken@chromium.org
==========

to

==========
Implement WEBGL_compressed_texture_es3_0 extension for WebGL 1/2

BUG=455568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-22 01:13:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 01:13:28]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kainino, 2016-09-22 05:58:55]

The CQ bit was checked by kainino@google.com

[commit-bot: I haz the power, 2016-09-22 05:59:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 06:35:05]

Description was changed from

==========
Implement WEBGL_compressed_texture_es3_0 extension for WebGL 1/2

BUG=455568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement WEBGL_compressed_texture_es3_0 extension for WebGL 1/2

BUG=455568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-22 06:35:06]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-22 06:37:10]

Description was changed from

==========
Implement WEBGL_compressed_texture_es3_0 extension for WebGL 1/2

BUG=455568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement WEBGL_compressed_texture_es3_0 extension for WebGL 1/2

BUG=455568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/993c5239d057144c1473d62cef9e45b2e1903174
Cr-Commit-Position: refs/heads/master@{#420271}
==========

[commit-bot: I haz the power, 2016-09-22 06:37:12]

Patchset 5 (id:??) landed as
https://crrev.com/993c5239d057144c1473d62cef9e45b2e1903174
Cr-Commit-Position: refs/heads/master@{#420271}